WIP: Fix NPE in PDEModelUtility.java (line 415) by adding null check (Fix #1404) #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
reviewed
Dec 29, 2024
There was a problem hiding this comment.
Hello @slvo-loading and thank you for your contribution.
First of all sorry for the late reply, I somehow lost track of this PR.
In general this change look reasonable, but one thing should be changed, see the remark below.
But it's a small change and I'm about to apply and push it directly to your branch to not further delay this change.
ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/util/PDEModelUtility.java
Outdated
Show resolved
Hide resolved
HannesWell
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary Of Change
Added a null guard to editor.getContextManager() to prevent NullPointerException (NPE).
Why this Change is Needed
An NPE occurs when too many processes are running and the user uses the context menu to close all tabs. This is caused by a race condition where dispose() is called while modifyEditorModel() is still running, resulting in getContextManager() returning null.
Related Issue
Fix #1404
Testing
Testing is in progress. We are working on a test where dispose() is called followed by modifyEditorModel() to verify that the null guard resolves the issue.