Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CSRF for logout #1294

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Enable CSRF for logout #1294

merged 1 commit into from
Jan 14, 2025

Conversation

rpoet-jh
Copy link
Contributor

This PR changes logout to POST to /logout when logout is clicked.

This PR goes with this pass-core PR, both need to merged at the same time.

@rpoet-jh rpoet-jh requested a review from markpatton January 13, 2025 19:32
@rpoet-jh rpoet-jh self-assigned this Jan 13, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rpoet-jh rpoet-jh mentioned this pull request Jan 13, 2025
Merged
markpatton
markpatton approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally in pass-docker and it worked well.

@rpoet-jh rpoet-jh merged commit aabe72d into main Jan 14, 2025
5 checks passed
@rpoet-jh rpoet-jh deleted the rdp-1100-logout-csrf branch January 16, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpatton markpatton markpatton approved these changes

Assignees

@rpoet-jh rpoet-jh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpoet-jh @markpatton