Set USER in docker #1293
Merged
Set USER in docker #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So container runs with unprivileged nginx user
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Dockerfile so the pass-ui docker container runs with the non-privileged nginx user.
Note that the base image was changed to nginxinc/nginx-unprivileged:1.27.3-alpine. This is what I found was the suggested way for running the nginx docker container with a non-privileged user. (https://hub.docker.com/_/nginx Running nginx as a non-root user). Also note the upgrade in nginx version to 1.27.3.
I have tested this locally in pass-docker and acceptance tests pass. I also tested the config where custom branding is mounted. L&F changed and tests passed.