Allowing shared subscriber group topics to match #911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looked to be a bug to me.
When I was configuring a client, and used
$share/groupname/topic
as the topic, no messages would be delivered.I traced it down to here: https://github.com/eclipse/paho.mqtt.java/blob/master/org.eclipse.paho.mqttv5.client/src/main/java/org/eclipse/paho/mqttv5/client/internal/CommsCallback.java#L611
At that point, the message would have come from
topic
, which does not match$share/groupname/topic
, and the message would be left undelivered.possibly related #827
Thank you for your time!
Signed-off-by: Nathan West [email protected]
Please make sure that the following boxes are checked before submitting your Pull Request, thank you!
used to sign the CLA) Hint: use the -s argument when committing.
you are fixing straight away that you add some Description about the bug and how this will fix it.