Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added thing message #2

Merged
merged 3 commits into from
Jan 26, 2024
Merged

added thing message #2

merged 3 commits into from
Jan 26, 2024

Conversation

alpsarica
Copy link
Contributor

Too solve the issues in Agent package (adding support for twin features and messages) thing message definition is added.

@nacidai
Copy link
Contributor

nacidai commented Jan 24, 2024

Two changes are needed:

  1. Please target the new enhancement branch not the main.
    2). The headers field in ditto messages includes some important data, see ProtocolEnvelope. So please make the headers field explicitly modeled to include the fields from the following example.

"headers": {
"reply-to":"att/cbcbcbc",
"ditto-originator":"nginx:ditto",
"response-required":false,"
"content-type":"application/json",
"correlation-id":"xccv-bababab-09998989-2424242"
}

@alpsarica alpsarica changed the base branch from main to enhancement-2 January 24, 2024 08:19
@alpsarica
Copy link
Contributor Author

@nacidai made the requested changes. Added ThingHeaders message to the Thing message.

@alpsarica
Copy link
Contributor Author

added correlation-id to ThingHeader message

@nacidai
Copy link
Contributor

nacidai commented Jan 26, 2024

Merging changes related. to #3

@nacidai nacidai merged commit 186727a into eclipse-muto:enhancement-2 Jan 26, 2024
1 check passed
nacidai added a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants