add custom gson config #1191
Closed
add custom gson config #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanshudan
force-pushed
the
hq/add-gson-config
branch
from
bbff454 to
2051767
Compare
rubenporras
reviewed
Jan 17, 2025
| @@ -208,6 +215,24 @@ public Class<? extends LanguageServer> getServerInterface() { | |||
| return super.getServerInterface(); | |||
| } | |||
|
|
|||
| @SuppressWarnings("unchecked") | |||
| @Override | |||
| public Consumer<GsonBuilder> getConfigureGson() { | |||
There was a problem hiding this comment.
I think you should use the method createLauncherBuilder as a template
There was a problem hiding this comment.
Indeed, I think you can create a helper method that can be reused by both methods, just passing CONFIGURE_GSON_ATTRIBUTE or LAUNCHER_BUILDER_ATTRIBUTE
|
Hi @yanshudan , I understand that you do not need this PR, so I am closing it, if I am wrong, please open it again. Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.