Ignoring failures when checking for hyperlinks #1186
+50
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding LanguageServers.addAllSuccessful as an alternative to LanguageServers.addAll so that exceptions from one of the requests being combined can be ignored. Then using this new method in OpenDeclarationHyperlinkDetector when combining the results from definitions, declarations, typeDefinitions, and implementions because some LSPs return errors instead of empty lists for some of these calls. Instead, we combine only the successful results when building the list of hyperlinks, ignoring the errors. This should resolve eclipse-lsp4e#1169
rubenporras
requested changes
Jan 16, 2025
| @@ -30,10 +30,16 @@ | |||
| <arguments> | |||
| </arguments> | |||
| </buildCommand> | |||
| <buildCommand> | |||
There was a problem hiding this comment.
this looks unrelated to the ticket you are resolving. Could you move the change to a new PR so that it can be looked at independently?
| @@ -12,6 +12,16 @@ | |||
| *******************************************************************************/ | |||
| package org.eclipse.lsp4e; | |||
|
|
|||
| import org.eclipse.core.resources.IProject; | |||
There was a problem hiding this comment.
it looks like organize imports is configured different than by default. Could you change it so that the PR does not change the order of the import in all the modified files?
| @@ -410,6 +410,30 @@ public static <T> CompletableFuture<List<T>> addAll(CompletableFuture<List<T>> a | |||
| return res; | |||
| } | |||
|
|
|||
| /** | |||
| * Combines two async lists of results into a single list by adding all the elements of the second list to the first one, | |||
There was a problem hiding this comment.
Suggested change
| * Combines two async lists of results into a single list by adding all the elements of the second list to the first one, | |
| * Combines async lists of results into a single list by adding all the elements of each lists to a new list |
| @@ -410,6 +410,30 @@ public static <T> CompletableFuture<List<T>> addAll(CompletableFuture<List<T>> a | |||
| return res; | |||
| } | |||
|
|
|||
| /** | |||
| * Combines two async lists of results into a single list by adding all the elements of the second list to the first one, | |||
| * ignoring abnormal results and only including succeses. | |||
There was a problem hiding this comment.
Suggested change
| * ignoring abnormal results and only including succeses. | |
| * ignoring any CompletableFuture that completed exceptionally. |
| .thenApply( v -> { | ||
| List<T> results = new ArrayList<>(futures.length); | ||
| for(CompletableFuture<List<T>> f : futures) { | ||
| if (!f.isCompletedExceptionally()) { |
There was a problem hiding this comment.
Instead of just ignoring exceptions, I think we should log them using LanguageServerPlugin.logError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding LanguageServers.addAllSuccessful as an alternative to LanguageServers.addAll so that exceptions from one of the requests being combined can be ignored. Then using this new method in OpenDeclarationHyperlinkDetector when combining the results from definitions, declarations, typeDefinitions, and implementions because some LSPs return errors instead of empty lists for some of these calls. Instead, we combine only the successful results when building the list of hyperlinks, ignoring the errors.
This should resolve #1169