Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure there is no precision loss on Number conversion #1692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbernard31
Copy link
Contributor

When converting Integer number (long/biginteger) or big decimal to double, ensure there is no precision loss.

Copy link

Unit Tests failed ! (more details)

Ensure your code build locally using:

mvn clean install

Or just launch tests :

mvn surefire:test

To launch unit tests only :

mvn surefire:test '-Dtest=!org.eclipse.leshan.integration.tests.**' -Dsurefire.failIfNoSpecifiedTests=false -Dskip.npm

Copy link

Integration Tests failed ! (more details)

Ensure your code build locally using:

mvn clean install

Or just launch all tests :

mvn surefire:test

To launch integration tests only :

mvn surefire:test '-Dtest=org.eclipse.leshan.integration.tests.**,!**/Redis*.java' -Dsurefire.failIfNoSpecifiedTests=false

Currently, some of our integration tests are flaky 😒 ,so do not hesitate to re-run in case of failure.

Copy link

ℹ️ Some tips :

If documentation or those automatic comments are not clear enough, please create a new issue to discus about how to enhance it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant