Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename maven artifacts to clearly see differnce with ID #1687

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename maven artifacts to clearly see differnce with ID #1687

wants to merge 1 commit into from

Conversation

sbernard31
Copy link
Contributor

See : #1677

@sbernard31 sbernard31 mentioned this pull request Jan 10, 2025
Open
jvermillard
jvermillard reviewed Jan 10, 2025
View reviewed changes
leshan-lwm2m-servers-shared/pom.xml
@@ -27,7 +27,7 @@ Contributors:
</parent>
<artifactId>leshan-lwm2m-servers-shared</artifactId>
<packaging>bundle</packaging>
<name>leshan-servers-shared</name>
<name>Leshan servers shared</name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<name>Leshan servers shared</name>
<name>Leshan Servers shared</name>

Copy link
Contributor Author

@sbernard31 sbernard31 Jan 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is a good idea 🤷 but I didn't add capital to shared and servers. Thinking that maybe this show this is not first class module. (As a user, you probably never depends of it directly)

If we decide to change that and add Capital to Servers, we probably need to also change :
[INFO] Leshan Demo servers shared ......................... SUCCESS [ 0.099 s] ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you still want to Capitalize with this explanation ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jvermillard do you still prefer Servers over servers ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvermillard jvermillard jvermillard left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernard31 @jvermillard