removed deprected method asList()
#3510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShivamChavan01
requested review from
manusa,
rohanKanojia and
sunix
as code owners
Eclipse JKube CI ReportStarted new GH workflow run for #3510 (2024-11-05T05:17:19Z) ⚙️ JKube E2E Tests (11677870931)
|
|
rohanKanojia
reviewed
Nov 5, 2024
| @@ -115,7 +122,9 @@ void inKubernetes_shouldNotCreateRoute() { | |||
| // When | |||
| new RouteEnricher(context).create(PlatformMode.kubernetes, klb); | |||
| // Then | |||
| assertThat(klb.build()).extracting(KubernetesList::getItems).asList().singleElement() | |||
| assertThat(klb.build()).extracting(KubernetesList::getItems) | |||
| .asInstanceOf(InstanceOfAssertFactories.list(ArrayList.class)) | |||
There was a problem hiding this comment.
Suggested change
| .asInstanceOf(InstanceOfAssertFactories.list(ArrayList.class)) | |
| .asInstanceOf(InstanceOfAssertFactories.list(HasMetadata.class)) |
rohanKanojia
reviewed
Nov 5, 2024
| @@ -77,7 +82,9 @@ void create_withServiceWithNoWebPort_shouldNotCreateRoute() { | |||
| // When | |||
| new RouteEnricher(context).create(PlatformMode.openshift, klb); | |||
| // Then | |||
| assertThat(klb.build()).extracting(KubernetesList::getItems).asList().singleElement() | |||
| assertThat(klb.build()).extracting(KubernetesList::getItems) | |||
| .asInstanceOf(InstanceOfAssertFactories.list(ArrayList.class)) | |||
There was a problem hiding this comment.
rohanKanojia
reviewed
Nov 5, 2024
| assertThat(klb.build()).extracting(KubernetesList::getItems).asList().singleElement() | ||
| .isInstanceOf(Service.class); | ||
| assertThat(klb.build()).extracting(KubernetesList::getItems) | ||
| .asInstanceOf(InstanceOfAssertFactories.list(ArrayList.class)) |
There was a problem hiding this comment.
rohanKanojia
reviewed
Nov 5, 2024
| @@ -54,7 +55,9 @@ void create_withNoServices_shouldNotCreateRoute() { | |||
| // When | |||
| new RouteEnricher(context).create(PlatformMode.openshift, klb); | |||
| // Then | |||
| assertThat(klb.build()).extracting(KubernetesList::getItems).asList().isEmpty(); | |||
| assertThat(klb.build()).extracting(KubernetesList::getItems) | |||
| .asInstanceOf(InstanceOfAssertFactories.list(ArrayList.class)) | |||
There was a problem hiding this comment.
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses Issue #3509, which involves replacing the deprecated
asList()method in theRouteEnricherBehavioralTestclass withasInstanceOf(InstanceOfAssertFactories.list(type.class)). This update is necessary to ensure compatibility with the latest AssertJ library and to maintain code quality.Fixes #3509
Type of change
test, version modification, documentation, etc.)
Checklist