-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix SpringBootWatcherIntegrationTest on macos #3013
fix SpringBootWatcherIntegrationTest on macos #3013
Conversation
… path, issue eclipse-jkube#3001 Signed-off-by: arman-yekkehkhani <[email protected]>
Eclipse JKube CI ReportStarted new GH workflow run for #3013 (2024-05-03T07:47:00Z) ⚙️ JKube E2E Tests (8935655031)
|
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3013 +/- ##
=============================================
+ Coverage 59.36% 70.86% +11.50%
- Complexity 4586 5086 +500
=============================================
Files 500 490 -10
Lines 21211 19591 -1620
Branches 2830 2526 -304
=============================================
+ Hits 12591 13884 +1293
+ Misses 7370 4479 -2891
+ Partials 1250 1228 -22 ☔ View full report in Codecov by Sentry. |
...oot/src/test/java/org/eclipse/jkube/springboot/watcher/SpringBootWatcherIntegrationTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Description
In order to fix failing tests on macos, we need to use the real path of jars instead of the absolute path. I.e. we need to use
private/var/folders/...
instead of/var/folders/...
. Thus, methodabsolutePath
is replaced with therealPath
.Fixes #3009
Type of change
test, version modification, documentation, etc.)
Checklist