feat (jkube-kit/enricher) : Add WellKnownLabelsEnricher for adding Kubernetes Recommended Well Known Labels #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #2523 (2024-01-17T14:03:44Z) ⚙️ JKube E2E Tests (7556731553)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2523 +/- ##
=============================================
+ Coverage 59.36% 70.15% +10.79%
- Complexity 4586 4919 +333
=============================================
Files 500 476 -24
Lines 21211 19198 -2013
Branches 2830 2482 -348
=============================================
+ Hits 12591 13468 +877
+ Misses 7370 4514 -2856
+ Partials 1250 1216 -34 ☔ View full report in Codecov by Sentry. |
18 tasks
rohanKanojia
force-pushed
the
pr/issue1700
branch
3 times, most recently
from
b30205a to
8b9d78b
Compare
|
With the current approach we are losing the ability to group the resources by group. It makes sense to me that we use of the |
rohanKanojia
force-pushed
the
pr/issue1700
branch
from
8b9d78b to
2c722db
Compare
manusa
reviewed
Jan 17, 2024
|
|
||
| @AllArgsConstructor | ||
| private enum Config implements Configs.Config { | ||
| USE_WELL_KNOWN_LABELS("useWellKnownLabels", "true"), |
There was a problem hiding this comment.
We should be consistent with this setting in other Enrichers.
For example, DebugEnricher uses ENABLED for the same purpose.
I understand that you inferred this from ProjectLabelEnricher.Config.USE_PROJECT_LABEL, but AFAIU that in this Enricher, it has a different purpose.
…bernetes Recommended Well Known Labels + Add WellKnownLabelEnricher that would add these labels to `.metadata` of all resources (also to `selector.matchLabels` in case of controller resources): - `app.kubernetes.io/component` - `app.kubernetes.io/managed-by` - `app.kubernetes.io/name` - `app.kubernetes.io/part-of` - `app.kubernetes.io/version` Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/issue1700
branch
from
2c722db to
90a65ad
Compare
|
manusa
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #1700
AbstractLabelEnricher.metadataof all resources (also toselector.matchLabelsin case of controller resources):app.kubernetes.io/componentapp.kubernetes.io/managed-byapp.kubernetes.io/nameapp.kubernetes.io/part-ofapp.kubernetes.io/versionapp.kubernetes.io/labels to integration tests that do strict checks.Type of change
test, version modification, documentation, etc.)
Checklist