Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed guava #2286 #2511

Closed

Conversation

Devashishbasu
Copy link
Contributor

Removed guava dependency
#2286

Removed guava dependency
@rohanKanojia
Copy link
Member

I think we're dependent on guava module due to jkube-kit/build/service/jib module.

@Devashishbasu
Copy link
Contributor Author

I think we're dependent on guava module due to jkube-kit/build/service/jib module.

So should I try to fix the Required Statuses or move to another issue??

@manusa
Copy link
Member

manusa commented Jan 3, 2024

The issue is about removing the Guava dependency (and its usages). Guava is used throughout (maybe less now after a few prior refactors) the project. It's not a simple replacement and it doesn't qualify as a good first issue.
The first step to remove any Guava-related piece of code is to provide tests to verify that the functionality provided by Guava remains after its removal.

@manusa manusa closed this Jan 3, 2024
@Devashishbasu Devashishbasu deleted the Remove-guava branch January 6, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants