Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#575] out of memory issue on windows #577

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Jan 9, 2025

Notes for Reviewer

  • The maximum supported shared memory size in Windows was 1GB which led to reduced supported payload size.
    • adjusted the maximum supported size to 128GB
  • The off_t type in Windows, used by several file functions, was a type alias to i32. This was updated to i64 (must be signed since -1 is used as error return value)
  • The function SetFilePointer supports only 32-bit, therefore it must be replaced with SetFilePointerEx

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Relates to #575

@elfenpiff elfenpiff requested a review from elBoberido January 9, 2025 10:47
@elfenpiff elfenpiff self-assigned this Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.24%. Comparing base (06c5c21) to head (0abdedb).

Files with missing lines Patch % Lines
iceoryx2-bb/posix/src/shared_memory.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
- Coverage   79.32%   79.24%   -0.09%     
==========================================
  Files         203      203              
  Lines       25321    25322       +1     
==========================================
- Hits        20087    20066      -21     
- Misses       5234     5256      +22     
Files with missing lines Coverage Δ
iceoryx2-bb/posix/src/shared_memory.rs 76.96% <0.00%> (-0.23%) ⬇️

... and 8 files with indirect coverage changes

@elfenpiff elfenpiff merged commit 3a3930b into eclipse-iceoryx:main Jan 9, 2025
47 checks passed
@elfenpiff elfenpiff deleted the iox2-575-out-of-memory-issue-on-windows branch January 9, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants