Skip to content

Commit

Permalink
The Felix plugin needs just the symbolic name setting
Browse files Browse the repository at this point in the history
- By default, Felix changes - to a . (dot)
- Fix for snapshot: Version included snapshot, that breaks usages
- sun packages in pfl-basic are not optional, sorry, you use Unsafe.
- I don't see the reason to run Felix install+deploy in pfl-basic

Signed-off-by: David Matějček <[email protected]>
  • Loading branch information
dmatej committed Feb 3, 2025
1 parent 3c72495 commit ffe5729
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 42 deletions.
7 changes: 1 addition & 6 deletions pfl-basic-tools/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,6 @@
<configuration>
<instructions>
<Bundle-SymbolicName>${project.groupId}.${project.artifactId}</Bundle-SymbolicName>
<Bundle-Name>${project.name}</Bundle-Name>
<Bundle-Version>${project.version}</Bundle-Version>
<Export-Package>
org.glassfish.pfl.basic.tools.*
</Export-Package>
</instructions>
</configuration>
</plugin>
Expand All @@ -67,7 +62,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
</plugin>
</plugin>
</plugins>
</build>

Expand Down
13 changes: 0 additions & 13 deletions pfl-basic/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,25 +31,12 @@
<configuration>
<instructions>
<Bundle-SymbolicName>${project.groupId}.${project.artifactId}</Bundle-SymbolicName>
<Bundle-Name>${project.name}</Bundle-Name>
<Bundle-Version>${project.version}</Bundle-Version>
<Export-Package>
!org.glassfish.pfl.basic.tools.*,
org.glassfish.pfl.basic.*
</Export-Package>
<Import-Package>
sun.misc;resolution:=optional,
sun.reflect;resolution:=optional,
*
</Import-Package>
</instructions>
</configuration>
<executions>
<execution>
<goals>
<goal>manifest</goal>
<goal>install</goal>
<goal>deploy</goal>
</goals>
</execution>
</executions>
Expand Down
7 changes: 0 additions & 7 deletions pfl-dynamic/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -55,19 +55,12 @@
<configuration>
<instructions>
<Bundle-SymbolicName>${project.groupId}.${project.artifactId}</Bundle-SymbolicName>
<Bundle-Name>${project.name}</Bundle-Name>
<Bundle-Version>${project.version}</Bundle-Version>
<Export-Package>
org.glassfish.pfl.dynamic.*
</Export-Package>
</instructions>
</configuration>
<executions>
<execution>
<goals>
<goal>manifest</goal>
<goal>install</goal>
<goal>deploy</goal>
</goals>
</execution>
</executions>
Expand Down
5 changes: 0 additions & 5 deletions pfl-test/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,6 @@
<configuration>
<instructions>
<Bundle-SymbolicName>${project.groupId}.${project.artifactId}</Bundle-SymbolicName>
<Bundle-Name>${project.name}</Bundle-Name>
<Bundle-Version>${project.version}</Bundle-Version>
<Export-Package>
org.glassfish.pfl.test.*
</Export-Package>
</instructions>
</configuration>
</plugin>
Expand Down
5 changes: 0 additions & 5 deletions pfl-tf-tools/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@
<configuration>
<instructions>
<Bundle-SymbolicName>${project.groupId}.${project.artifactId}</Bundle-SymbolicName>
<Bundle-Name>${project.name}</Bundle-Name>
<Bundle-Version>${project.version}</Bundle-Version>
<Export-Package>
org.glassfish.pfl.tf.tools.*
</Export-Package>
</instructions>
</configuration>
</plugin>
Expand Down
6 changes: 0 additions & 6 deletions pfl-tf/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,6 @@
<configuration>
<instructions>
<Bundle-SymbolicName>${project.groupId}.${project.artifactId}</Bundle-SymbolicName>
<Bundle-Name>${project.name}</Bundle-Name>
<Bundle-Version>${project.version}</Bundle-Version>
<Export-Package>
org.glassfish.pfl.tf.spi.*,
org.glassfish.pfl.tf.timer.*
</Export-Package>
</instructions>
</configuration>
</plugin>
Expand Down

0 comments on commit ffe5729

Please sign in to comment.