Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Update 'Factory' E2E test #23311

Merged
merged 6 commits into from
Jan 31, 2025
Merged

[Test] Update 'Factory' E2E test #23311

merged 6 commits into from
Jan 31, 2025

Conversation

artaleks9
Copy link
Contributor

What does this PR do?

  • Updates the Factory E2E test to do checking test-cases of factory with gitlab server private repo when OAuth token is expired.
  • Adds new environment variable: DELETE_WORKSPACE_ON_SUCCESSFUL_TEST to tests/e2e/constants/BASE_TEST_CONSTANTS.ts
  • Adds new environment variable: IS_RESTART_EXISTING_WORKSPACE to tests/e2e/constants/BASE_TEST_CONSTANTS.ts

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

Run the Factory.spec.ts as usual

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@artaleks9 artaleks9 requested review from SkorikSergey and removed request for musienko-maxim January 10, 2025 12:26
@artaleks9 artaleks9 self-assigned this Jan 10, 2025
@artaleks9 artaleks9 added area/qe status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jan 10, 2025
@artaleks9
Copy link
Contributor Author

@dmytro-ndp, I think that all comments need to be accepted.
Will fix.

@artaleks9 artaleks9 added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jan 16, 2025
@artaleks9 artaleks9 removed the status/in-progress This issue has been taken by an engineer and is under active development. label Jan 31, 2025
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

@artaleks9 artaleks9 merged commit 1b2592f into main Jan 31, 2025
4 of 5 checks passed
@artaleks9 artaleks9 deleted the update-factory branch January 31, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants