-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Update 'Factory' E2E test #23311
Merged
Merged
+78
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artaleks9
requested review from
SkorikSergey
and removed request for
musienko-maxim
January 10, 2025 12:26
artaleks9
added
area/qe
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
labels
Jan 10, 2025
dmytro-ndp
reviewed
Jan 10, 2025
dmytro-ndp
reviewed
Jan 10, 2025
dmytro-ndp
reviewed
Jan 10, 2025
dmytro-ndp
reviewed
Jan 10, 2025
dmytro-ndp
reviewed
Jan 10, 2025
@dmytro-ndp, I think that all comments need to be accepted. |
artaleks9
added
status/in-progress
This issue has been taken by an engineer and is under active development.
and removed
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
labels
Jan 16, 2025
artaleks9
removed
the
status/in-progress
This issue has been taken by an engineer and is under active development.
label
Jan 31, 2025
dmytro-ndp
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Factory
E2E test to do checking test-cases of factory with gitlab server private repo when OAuth token is expired.DELETE_WORKSPACE_ON_SUCCESSFUL_TEST
totests/e2e/constants/BASE_TEST_CONSTANTS.ts
IS_RESTART_EXISTING_WORKSPACE
totests/e2e/constants/BASE_TEST_CONSTANTS.ts
Screenshot/screencast of this PR
Factory
E2E test on local Jenkins with PR changes:restart-ws-logs.txt
factory-oauth-no-delete-ws-logs.txt
What issues does this PR fix or reference?
How to test this PR?
Run the
Factory.spec.ts
as usualPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.