Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add README.md with describing test scenario for WTO #23127

Closed
wants to merge 2 commits into from
Closed

Add README.md with describing test scenario for WTO #23127

wants to merge 2 commits into from

Conversation

musienko-maxim
Copy link
Contributor

dmytro-ndp
dmytro-ndp reviewed Sep 3, 2024
View reviewed changes
tests/e2e/specs/web-terminal/Readme.md

5. Verify Admin Session:
* Execute the command oc whoami and verify that the session is running under the admin user.
* Since the terminal is canvas-based and difficult to read with WebDriver, read the DevWorkspace object, parse the YAML, and extract the username.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean "and extract the username manually"?

Copy link
Contributor Author

@musienko-maxim musienko-maxim Sep 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means we get webterminal object in YAML format (oc get dw -n -o yaml), parse it, and make sure, that we have been logged in as the proper user. YAML.parse(devWorkspaceYaml).items[0].metadata.name

che/tests/e2e/specs/web-terminal/WebTerminalUnderAdmin.spec.ts

Line 57 in 0059eaa

const devWorkspaceYaml: string = shellExecutor.executeArbitraryShellScript(

@oharan2
Copy link

oharan2 commented Sep 11, 2024

/lgtm

ibuziuk
ibuziuk requested changes Sep 12, 2024
View reviewed changes
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm not following why we are having WTO! test scenario in Eclipse Che upstream ?

@musienko-maxim
Copy link
Contributor Author

musienko-maxim commented Sep 12, 2024 •
edited
Loading

Sorry, I'm not following up on why we are having WTO! test scenario in Eclipse Che upstream?
Well, we have an interesting situation - we use existed codebase for also for WTO testing and I decided to add this one to this place. I am planning to rewrite the test using GO + selenium and move it to the WTO project but need to invest more time.
So, if Che Upstream is no better place for this I am ready to get new suggestions.

@ibuziuk
Copy link
Member

ibuziuk commented Sep 12, 2024

WTO repo is https://github.com/redhat-developer/web-terminal-operator

@musienko-maxim
Copy link
Contributor Author

I created a dedicated issue for that because the problem is more complex and includes not test scenario: https://issues.redhat.com/projects/WTO/issues/WTO-308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuziuk ibuziuk ibuziuk requested changes

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@SkorikSergey SkorikSergey SkorikSergey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@musienko-maxim @oharan2 @ibuziuk @dmytro-ndp @SkorikSergey