[Test] Add test that revokes OAuth access from Dashboard #22762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkorikSergey
added
status/in-progress
SkorikSergey
added
status/code-review
che-bot
added
the
target/branch
SkorikSergey
requested review from
musienko-maxim,
nickboldt,
ScrewTSW and
dmytro-ndp
as code owners
|
@SkorikSergey: do you have successful RevokeOauth.spec.ts test run to review? |
dmytro-ndp
reviewed
Jan 12, 2024
dmytro-ndp
reviewed
Jan 12, 2024
Yes, checked with GitHub service. |
SkorikSergey
force-pushed
the
addRevokeOauthTest
branch
from
227657d to
ebfad7f
Compare
SkorikSergey
force-pushed
the
addRevokeOauthTest
branch
from
ebfad7f to
02c74bb
Compare
SkorikSergey
force-pushed
the
addRevokeOauthTest
branch
from
c6d66af to
1fa7c9f
Compare
dmytro-ndp
reviewed
Jan 15, 2024
| @@ -14,14 +14,25 @@ import { By } from 'selenium-webdriver'; | |||
| import { DriverHelper } from '../../utils/DriverHelper'; | |||
| import { Logger } from '../../utils/Logger'; | |||
|
|
|||
| enum GitServices { | |||
| GITHUB = 'github', | |||
There was a problem hiding this comment.
IMHO we can avoid duplication if use FACTORY_TEST_CONSTANTS > GitProviderType https://github.com/eclipse/che/blob/07ed023e6d80e46c9a1759d7ff25a77d4e9ab535/tests/e2e/constants/FACTORY_TEST_CONSTANTS.ts#L12-L18
dmytro-ndp
reviewed
Jan 15, 2024
|
|
||
| getServiceConfig(service: string): string { | ||
| const gitService: { [key: string]: string } = { | ||
| [GitServices.GITHUB]: 'GitHub', |
There was a problem hiding this comment.
See comment in https://github.com/eclipse/che/pull/22762/files#r1452432608
dmytro-ndp
approved these changes
Jan 15, 2024
dmytro-ndp
approved these changes
Jan 15, 2024
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This test automate revoke OAuth access from User Preferences page.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-4841
How to test this PR?
PR Checklist
▼ UserPreferences.openUserPreferencesPage ‣ DriverHelper.waitAndClick - By(xpath, //header//button/span[text()!=""]//parent::button) ‣ DriverHelper.waitVisibility - By(xpath, //header//button/span[text()!=""]//parent::button) ‣ DriverHelper.waitVisibility - element is located and is visible. ‣ DriverHelper.waitAndClick - By(xpath, //button[text()="User Preferences"]) ‣ DriverHelper.waitVisibility - By(xpath, //button[text()="User Preferences"]) ‣ DriverHelper.waitVisibility - element is located and is visible. ‣ DriverHelper.waitVisibility - By(xpath, //h1[text()="User Preferences"]) ‣ DriverHelper.waitVisibility - element is located and is visible. ▼ UserPreferences.openGitServicesTab ‣ DriverHelper.waitAndClick - By(xpath, //button[text()="Git Services"]) ‣ DriverHelper.waitVisibility - By(xpath, //button[text()="Git Services"]) ‣ DriverHelper.waitVisibility - element is located and is visible. ▼ UserPreferences.revokeGitService ▼ UserPreferences.selectListItem - of the 'GitHub' list item ‣ DriverHelper.waitAndClick - By(xpath, //tr[td[text()='GitHub']]//input) ‣ DriverHelper.waitVisibility - By(xpath, //tr[td[text()='GitHub']]//input) ‣ DriverHelper.waitVisibility - element is located and is visible. ‣ DriverHelper.waitAndClick - By(xpath, //button[text()="Revoke"]) ‣ DriverHelper.waitVisibility - By(xpath, //button[text()="Revoke"]) ‣ DriverHelper.waitVisibility - element is located and is visible. ‣ DriverHelper.waitVisibility - By(xpath, //span[text()="Revoke Git Services"]) ‣ DriverHelper.waitVisibility - element is located and is visible. ‣ DriverHelper.waitAndClick - By(xpath, //input[@data-testid="warning-info-checkbox"]) ‣ DriverHelper.waitVisibility - By(xpath, //input[@data-testid="warning-info-checkbox"]) ‣ DriverHelper.waitVisibility - element is located and is visible. ‣ DriverHelper.waitAndClick - By(xpath, //button[@data-testid="revoke-button" and not(@disabled)]) ‣ DriverHelper.waitVisibility - By(xpath, //button[@data-testid="revoke-button" and not(@disabled)]) ‣ DriverHelper.waitVisibility - element is located and is visible. ‣ DriverHelper.waitDisappearance - By(xpath, //tr[td[text()='GitHub']]//input) ‣ DriverHelper.waitDisappearanceBoolean - By(xpath, //tr[td[text()='GitHub']]//input) ‣ DriverHelper.isVisible - By(xpath, //tr[td[text()='GitHub']]//input) ‣ DriverHelper.wait - (1000 milliseconds) ‣ DriverHelper.isVisible - By(xpath, //tr[td[text()='GitHub']]//input) ✔ Revoke OAuth testAs the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.