Add namespace context for exec command in the test #22713
Conversation
musienko-maxim
requested review from
nickboldt,
ScrewTSW and
dmytro-ndp
as code owners
che-bot
added
kind/enhancement
|
@musienko-maxim : should PR fix the issue #22575 ? Asking, because |
|
Yes, we can close the issue because this PR should fix the #22575. If we get some other problems, I hope it won't happen - we can create new issue |
che-bot
removed
the
status/code-review
|
@musienko-maxim : I don't think we can close the issue #22575, because the test has failed: https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/16241/consoleFull |
| ); | ||
| expect(initContainerName).contains('che-code-injector'); | ||
| }); | ||
|
|
||
| test('Check expected environment variables', function (): void { | ||
| const envList: string = shellExecutor.executeArbitraryShellScript( | ||
| `${API_TEST_CONSTANTS.TS_API_TEST_KUBERNETES_COMMAND_LINE_TOOL} exec -i ${podName} -c tools -- sh -c env` | ||
| `${API_TEST_CONSTANTS.TS_API_TEST_KUBERNETES_COMMAND_LINE_TOOL} -n admin-devspaces exec -i ${podName} -c tools -- sh -c env` |
There was a problem hiding this comment.
admin-devspaces is hardcoded
|
@musienko-maxim : if I understood it correctly, there is no need to pass |
What does this PR do?
The test applies oc commands without the name of the namespace.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-5065
#22575
How to test this PR?:
Set the env. Where will be a test run for the Namespace/OpenShift project.: For example,
export TEST_NAMESPACE=admin-devspacesReview and merge PR, get results from the Jenkins pipeline
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.