-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and rework PredefinedNamespace test #22693
Conversation
I can't entirely agree with saving the UI part. |
@musienko-maxim : the test was initially created to check user namespace provisioning using Dashboard. @ibuziuk, @l0rd: could you, please, say if it would be enough to test user namespace provisioning at DevWorkspace level only not using Che Dashboard and Che Server? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to remove the UI logic and fallback on oc / kubect
What does this PR do?
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-5345
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.