Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and fix problems for running DevFile API tests #22677

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

musienko-maxim
Copy link
Contributor

What does this PR do?

Fix and improve problems which were described in the https://issues.redhat.com/browse/CRW-5023 issue

During this work, I found the following problems:
* When we generate files from https://api.github.com/repos/eclipse-che/che-devfile-registry/contents/devfiles  We can often face rate limits for unauthorized requests. To increase limits, we can add a GitHub token with an auth header 
* When we use the Inbuld devfile registry on OpenShift and Kubernetes platform - the objects to devfiles URLs are different and we need to manage it.
* There is no way to set k8s custom namespace/OpenShift projects for running APIDevfiles tests

Screenshot/screencast of this PR

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-5023

How to test this PR?

MOCHA_DIRECTORY=api;
NODE_TLS_REJECT_UNAUTHORIZED=0;
TEST_NAMESPACE=admin-che;
TS_API_TEST_KUBERNETES_COMMAND_LINE_TOOL=kubectl;
TS_PLATFORM=kubernetes;
TS_SELENIUM_BASE_URL=https://192.168.49.2.nip.io/;
USERSTORY=DevfileAcceptanceTestAPI

PR Checklist

As the author of this Pull Request, I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added target/branch Indicates that a PR will be merged into a branch other than master. kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Nov 19, 2023
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

@musienko-maxim musienko-maxim merged commit ce17960 into main Nov 23, 2023
2 checks passed
@musienko-maxim musienko-maxim deleted the CRW-5023 branch November 23, 2023 20:53
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants