[CRW-5013] Fix up factory E2E test to avoid 'Restricted' mode #22672
Conversation
artaleks9
added
status/code-review
artaleks9
requested review from
musienko-maxim,
nickboldt,
ScrewTSW and
dmytro-ndp
as code owners
artaleks9
requested review from
dmytro-ndp
and removed request for
dmytro-ndp
che-bot
added
kind/bug
artaleks9
removed
the
kind/bug
| * manage to 'Trusted' Workspace Mode, when the trust dialog does not appear | ||
| * @param scmProvider SingleScmProvider object | ||
| */ | ||
| async manageWorkspaceTrust(scmProvider: SingleScmProvider): Promise<void> { |
There was a problem hiding this comment.
IMHO manageWorkspaceTrust method name is too vague.
What about performManageWorkspaceTrustBox() method name?
Also it would be nice to say in method comment that it is the box appeared in Source Control View.
che-bot
added
the
kind/bug
| @@ -131,6 +131,8 @@ suite( | |||
| const scmView: NewScmView = new NewScmView(); | |||
| await driverHelper.waitVisibility(webCheCodeLocators.ScmView.inputField); | |||
| [scmProvider, ...rest] = await scmView.getProviders(); | |||
| await projectAndFileTests.manageWorkspaceTrust(scmProvider); | |||
There was a problem hiding this comment.
IMHO, we can make the logic of script more obvious and avoid second execution of [scmProvider, ...rest] = await scmView.getProviders() when extract if (scmProvider === undefined) { verification from manageWorkspaceTrust() to test script level.
|
@artaleks9 : if I understood it correctly this script doesn't check Source Control View functionality itself, but making it possible to proceed with the whole test scenario, which looks like a workaround. Am I right? |
|
@dmytro-ndp |
che-bot
removed
the
status/code-review
What does this PR do?
Fixes a problem of failed factory tests due unexpected 'Restricted' Mode
Screenshot/screencast of this PR
Trial launches of
factory-testspipeline showed successful completion:-- https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/blue/organizations/jenkins/Testing%2Fe2e%2Fcomplex%2Flatest%2Ffactory%2Ffactory-tests/detail/factory-tests/254/pipeline/208/
-- https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/blue/organizations/jenkins/Testing%2Fe2e%2Fcomplex%2Flatest%2Ffactory%2Ffactory-tests/detail/factory-tests/250/pipeline/133/
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-5013
https://issues.redhat.com/browse/CRW-5295
https://issues.redhat.com/browse/CRW-5297
https://issues.redhat.com/browse/CRW-5298
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.