-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Advanced authorization #619
Conversation
Signed-off-by: Anatolii Bazko <[email protected]>
Skipping CI for Draft Pull Request. |
...rg/eclipse/che/workspace/infrastructure/kubernetes/authorization/AuthorizationException.java
Outdated
Show resolved
Hide resolved
...he/workspace/infrastructure/kubernetes/authorization/KubernetesAuthorizationCheckerImpl.java
Outdated
Show resolved
Hide resolved
assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties
Outdated
Show resolved
Hide resolved
...rg/eclipse/che/workspace/infrastructure/kubernetes/namespace/KubernetesNamespaceFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, though I haven't tested the changes.
/retest |
...he/workspace/infrastructure/kubernetes/authorization/KubernetesAuthorizationCheckerImpl.java
Outdated
Show resolved
Hide resolved
...he/workspace/infrastructure/kubernetes/authorization/KubernetesAuthorizationCheckerImpl.java
Outdated
Show resolved
Hide resolved
...he/workspace/infrastructure/kubernetes/authorization/KubernetesAuthorizationCheckerTest.java
Outdated
Show resolved
Hide resolved
...he/workspace/infrastructure/kubernetes/authorization/KubernetesAuthorizationCheckerTest.java
Outdated
Show resolved
Hide resolved
.../che/workspace/infrastructure/openshift/authorization/OpenShiftAuthorizationCheckerImpl.java
Outdated
Show resolved
Hide resolved
.../che/workspace/infrastructure/openshift/authorization/OpenShiftAuthorizationCheckerImpl.java
Outdated
Show resolved
Hide resolved
.../che/workspace/infrastructure/openshift/authorization/OpenShiftAuthorizationCheckerTest.java
Outdated
Show resolved
Hide resolved
.../che/workspace/infrastructure/openshift/authorization/OpenShiftAuthorizationCheckerTest.java
Outdated
Show resolved
Hide resolved
.../che/workspace/infrastructure/openshift/authorization/OpenShiftAuthorizationCheckerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, ibuziuk, tolusha, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Build 3.11 :: server_3.x/289: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5493: Console, Changes, Git Data |
Build 3.11 :: push-latest-container-to-quay_3.x/3854: Console, Changes, Git Data |
Build 3.11 :: get-sources-rhpkg-container-build_3.x/5372: server : 3.x :: Build 57369560 : quay.io/devspaces/server-rhel8:3.11-21 |
Build 3.11 :: server_3.x/289: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5493 triggered |
Build 3.11 :: update-digests_3.x/5123: Console, Changes, Git Data |
Build 3.11 :: update-digests_3.x/5123: No new images detected: nothing to do! |
What does this PR do?
feat: Advanced authorization
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-4805
How to test this PR?
See eclipse-che/che-operator#1789
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.