Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove plugin registry pod if openVSX configured #1913

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Oct 7, 2024

What does this PR do?

fix: Remove plugin registry pod if openVSX configured

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-7473

How to test this PR?

  1. Prepare a patch file if needed:
cat > /tmp/cr-patch.yaml <<EOF
apiVersion: org.eclipse.che/v2
kind: CheCluster
spec: {}
EOF
  1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Copy link

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Copy link

openshift-ci bot commented Oct 8, 2024

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-che-behind-proxy dff6d61 link true /test v14-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tolusha tolusha merged commit 891a727 into main Oct 8, 2024
20 of 21 checks passed
@tolusha tolusha deleted the CRW-7473 branch October 8, 2024 13:23
@devstudio-release
Copy link

Build 3.18 :: operator_3.x/411: Console, Changes, Git Data

tolusha added a commit that referenced this pull request Oct 8, 2024
* fix: Remove plugin registry pod if openVSX configured

Signed-off-by: Anatolii Bazko <[email protected]>
@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: operator_3.x/411: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7791 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

tolusha added a commit that referenced this pull request Oct 8, 2024
* fix: Remove plugin registry pod if openVSX configured

Signed-off-by: Anatolii Bazko <[email protected]>
@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: copyIIBsToQuay/2831: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.18 :: sync-to-downstream_3.x/7793: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7800 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.18 :: operator-bundle_3.x/3654: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7793 triggered

@devstudio-release
Copy link

Build 3.18 :: update-digests_3.x/7718: SUCCESS

Detected new images: rebuild operator-bundle
* devspaces-operator; /DS_CI/operator-bundle_3.x/3654 triggered

@devstudio-release
Copy link

Build 3.18 :: dsc_3.x/2014: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.18 :: dsc_3.x/2014: SUCCESS

3.18.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants