Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add allowedSource property #1893

Merged
merged 3 commits into from
Sep 11, 2024
Merged

feat: Add allowedSource property #1893

merged 3 commits into from
Sep 11, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Sep 5, 2024

What does this PR do?

Add allowedSource property

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#23030

How to test this PR?

  1. Prepare a patch file if needed:
cat > /tmp/cr-patch.yaml <<EOF
apiVersion: org.eclipse.che/v2
kind: CheCluster
spec: {}
EOF
  1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Copy link

openshift-ci bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Copy link

openshift-ci bot commented Sep 10, 2024

New changes are detected. LGTM label has been removed.

Signed-off-by: Anatolii Bazko <[email protected]>
Copy link

openshift-ci bot commented Sep 11, 2024

@tolusha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-che-behind-proxy 79dbd0a link true /test v14-che-behind-proxy
ci/prow/v14-devworkspace-happy-path 79dbd0a link true /test v14-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tolusha tolusha merged commit 4b62b54 into main Sep 11, 2024
19 of 21 checks passed
@tolusha tolusha deleted the 23030 branch September 11, 2024 09:28
@devstudio-release
Copy link

Build 3.17 :: operator_3.x/396: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.17 :: operator_3.x/396: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7698 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.17 :: copyIIBsToQuay/2788: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: sync-to-downstream_3.x/7699: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7691 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.17 :: operator-bundle_3.x/3610: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7699 triggered

@devstudio-release
Copy link

Build 3.17 :: dsc_3.x/1994: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: update-digests_3.x/7526: SUCCESS

Detected new images: rebuild operator-bundle
* devspaces-operator; /DS_CI/operator-bundle_3.x/3610 triggered

@devstudio-release
Copy link

Build 3.17 :: dsc_3.x/1994: SUCCESS

3.17.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants