Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Mount RELATED_IMAGES_sample env vars into dashboard container #1887

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix: Mount RELATED_IMAGES_sample env vars into dashboard container #1887

merged 1 commit into from
Aug 20, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Aug 20, 2024

What does this PR do?

Mount RELATED_IMAGES_sample env vars into dashboard container

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-6918

How to test this PR?

  1. Prepare a patch file if needed:
cat > /tmp/cr-patch.yaml <<EOF
apiVersion: org.eclipse.che/v2
kind: CheCluster
spec: {}
EOF
  1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 20, 2024

@tolusha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-che-behind-proxy 5a29e05 link true /test v14-che-behind-proxy
ci/prow/v14-devworkspace-happy-path 5a29e05 link true /test v14-devworkspace-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tolusha tolusha merged commit 145a76e into main Aug 20, 2024
19 of 21 checks passed
@tolusha tolusha deleted the CRW-6918 branch August 20, 2024 13:38
@devstudio-release
Copy link

Build 3.17 :: operator_3.x/390: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: sync-to-downstream_3.x/7532: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7513: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: operator-bundle_3.x/3496: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: sync-to-downstream_3.x/7533: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7514: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: push-latest-container-to-quay_3.x/4886: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7513: SUCCESS

devspaces-operator : 3.x :: Build 63490987 : quay.io/devspaces/devspaces-rhel8-operator:3.17-4
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/4886 triggered

@devstudio-release
Copy link

Build 3.17 :: operator_3.x/390: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7532 triggered

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7514: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 63494851 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.17 :: update-digests_3.x/7368: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: operator-bundle_3.x/3497: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: sync-to-downstream_3.x/7534: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7515: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7515: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 63497441 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.17 :: operator-bundle_3.x/3498: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: sync-to-downstream_3.x/7535: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7516: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7516: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 63505349 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.17 :: operator-bundle_3.x/3499: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: sync-to-downstream_3.x/7537: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7518: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7518: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 63516318 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.17 :: operator-bundle_3.x/3500: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: sync-to-downstream_3.x/7538: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7519: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7519: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 63518347 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.17 :: operator-bundle_3.x/3501: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: sync-to-downstream_3.x/7539: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7520: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7520: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 63525157 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.17 :: operator-bundle_3.x/3502: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: sync-to-downstream_3.x/7540: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7521: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7521: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 63529945 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

@devstudio-release
Copy link

Build 3.17 :: operator-bundle_3.x/3504: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: sync-to-downstream_3.x/7543: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7524: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: get-sources-rhpkg-container-build_3.x/7524: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 63537315 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SDawley SDawley Awaiting requested review from SDawley SDawley is a code owner

@ibuziuk ibuziuk Awaiting requested review from ibuziuk ibuziuk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tolusha @devstudio-release