Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Kubernetes secret name in oAuthSecret, fallback to plain text #1836

Merged
merged 5 commits into from
May 14, 2024

Conversation

guydog28
Copy link
Contributor

@guydog28 guydog28 commented May 9, 2024

What does this PR do?

Check the values for oAuthSecret to see if it is the names of a Kubernetes secret in the namespace, otherwise falls back to plain text.

What issues does this PR fix or reference?

eclipse-che/che#22950

How to test this PR?

  • kubernetes only
  • specify a secret with a key oAuthSecret, and put the secret name as the oAuthSecret

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Copy link

openshift-ci bot commented May 9, 2024

Hi @guydog28. Thanks for your PR.

I'm waiting for a eclipse-che member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: guydog28

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

}

// Convert the byte slice to a string
logrus.Infof("Using oAuthSecret found in Kubernetes secret %s", ctx.CheCluster.Spec.Networking.Auth.OAuthSecret)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove logging, since it will be printed on the every reconcile loop and it will spam the console.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

pkg/deploy/gateway/oauth_proxy.go Show resolved Hide resolved
@tolusha
Copy link
Contributor

tolusha commented May 14, 2024

Sounds good.
Please run the command to update dev resources build/scripts/docker-run.sh make update-dev-resources and commit all updated files.

@guydog28
Copy link
Contributor Author

Sounds good. Please run the command to update dev resources build/scripts/docker-run.sh make update-dev-resources and commit all updated files.

Done.

@tolusha tolusha merged commit 192216b into eclipse-che:main May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants