Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add storage size #1815

Merged
merged 1 commit into from
Mar 7, 2024
Merged

chore: add storage size #1815

merged 1 commit into from
Mar 7, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Mar 7, 2024

What does this PR do?

Add storage size to devfile to make tests passed

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#22841

How to test this PR?

  1. Prepare a patch file if needed:
cat > /tmp/cr-patch.yaml <<EOF
apiVersion: org.eclipse.che/v2
kind: CheCluster
spec: {}
EOF
  1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Anatolii Bazko <[email protected]>
Copy link

openshift-ci bot commented Mar 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.66%. Comparing base (d4d21a2) to head (fed5065).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1815   +/-   ##
=======================================
  Coverage   59.66%   59.66%           
=======================================
  Files          74       74           
  Lines        9099     9099           
=======================================
  Hits         5429     5429           
  Misses       3294     3294           
  Partials      376      376           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tolusha tolusha marked this pull request as ready for review March 7, 2024 13:02
@tolusha tolusha requested review from SDawley and ibuziuk as code owners March 7, 2024 13:02
@tolusha tolusha changed the title [TEST] chore: add storage size chore: add storage size Mar 7, 2024
Copy link

openshift-ci bot commented Mar 7, 2024

@tolusha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-che-behind-proxy fed5065 link true /test v14-che-behind-proxy
ci/prow/v14-operator-test fed5065 link true /test v14-operator-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha tolusha merged commit e2a42e4 into main Mar 7, 2024
21 of 23 checks passed
@tolusha tolusha deleted the test branch March 7, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant