Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CRW-5336 bump up to Traefik 2.9.10 (last 2.9.z that builds with golang 1.20) #1793

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

nickboldt
Copy link
Contributor

@nickboldt nickboldt commented Dec 5, 2023

What does this PR do?

chore: CRW-5336 bump up to Traefik 2.9.10 (last 2.9.z that builds with golang 1.20)

Change-Id: I56806f25fb8e62dc3e6ece4ca4f458a7418f53cf
Signed-off-by: nickboldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

chore: CRW-5336 bump up to Traefik 2.9.10 = 4ed3964b3; remove unused TRAEFIK_SHA in dockerfile

2.9.10 is the last 2.9.z that builds with golang 1.20 (which we need in downstream to build from sources).

We could potentially move up to 2.10.4 instead, which also uses golang 1.20: https://github.com/traefik/traefik/blob/v2.10.4/go.mod

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…h golang 1.20)

Change-Id: I56806f25fb8e62dc3e6ece4ca4f458a7418f53cf
Signed-off-by: nickboldt <[email protected]>
Copy link

openshift-ci bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nickboldt nickboldt changed the title chore: CRW-5336 bump up to Traefik 2.9.10... chore: [CRW-5336](https://issues.redhat.com//browse/CRW-5336) bump up to Traefik 2.9.10 (last 2.9.z that builds with golang 1.20) Dec 5, 2023
@nickboldt nickboldt changed the title chore: [CRW-5336](https://issues.redhat.com//browse/CRW-5336) bump up to Traefik 2.9.10 (last 2.9.z that builds with golang 1.20) chore: https://issues.redhat.com//browse/CRW-5336 bump up to Traefik 2.9.10 (last 2.9.z that builds with golang 1.20) Dec 5, 2023
@nickboldt nickboldt changed the title chore: https://issues.redhat.com//browse/CRW-5336 bump up to Traefik 2.9.10 (last 2.9.z that builds with golang 1.20) chore: CRW-5336 bump up to Traefik 2.9.10 (last 2.9.z that builds with golang 1.20) Dec 5, 2023
@nickboldt
Copy link
Contributor Author

Change-Id: I7bb922bb57ed2602fcf4fd0f6ab912f025011eb7
Signed-off-by: nickboldt <[email protected]>
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (038eaa5) 59.71% compared to head (e060369) 59.46%.
Report is 1 commits behind head on main.

Files Patch % Lines
api/v2/zz_generated.deepcopy.go 0.00% 34 Missing ⚠️
pkg/deploy/server/server_configmap.go 25.00% 5 Missing and 1 partial ⚠️
pkg/deploy/server/server_reconciler.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1793      +/-   ##
==========================================
- Coverage   59.71%   59.46%   -0.26%     
==========================================
  Files          71       71              
  Lines        8658     8703      +45     
==========================================
+ Hits         5170     5175       +5     
- Misses       3133     3172      +39     
- Partials      355      356       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Anatolii Bazko <[email protected]>
@tolusha
Copy link
Contributor

tolusha commented Dec 6, 2023

/retest

@nickboldt nickboldt merged commit 8dc7d82 into main Dec 6, 2023
13 of 15 checks passed
@nickboldt nickboldt deleted the traefik2.9.10 branch December 6, 2023 14:39
@devstudio-release
Copy link

Build 3.11 :: operator_3.x/328: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: operator_3.x/328: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5513 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/5146: UNSTABLE

No new images detected: nothing to do!

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2265: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: copyIIBsToQuay/2320: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: sync-to-downstream_3.x/5736: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5608 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.12 :: operator-bundle_3.x/2474: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5736 triggered

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1677: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1677: SUCCESS

3.12.0-CI

@devstudio-release
Copy link

Build 3.12 :: copyIIBsToQuay/2320: SUCCESS

3.12
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.12-39
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.14-640266-533291-s390x
  + quay.io/devspaces/iib:3.12-v4.14-s390x
  + quay.io/devspaces/iib:next-v4.14-s390x
  + quay.io/devspaces/iib:3.12-v4.13-640261-533286-s390x
  + quay.io/devspaces/iib:3.12-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.12-v4.12-640355-533281-s390x
  + quay.io/devspaces/iib:3.12-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.12-v4.11-640352-533277-s390x
  + quay.io/devspaces/iib:3.12-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.14-640266-533291-x86_64
  + quay.io/devspaces/iib:3.12-v4.14-x86_64
  + quay.io/devspaces/iib:next-v4.14-x86_64
  + quay.io/devspaces/iib:3.12-v4.13-640261-533286-x86_64
  + quay.io/devspaces/iib:3.12-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.12-v4.12-640355-533281-x86_64
  + quay.io/devspaces/iib:3.12-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.12-v4.11-640352-533277-x86_64
  + quay.io/devspaces/iib:3.12-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.14-640266-533291-ppc64le
  + quay.io/devspaces/iib:3.12-v4.14-ppc64le
  + quay.io/devspaces/iib:next-v4.14-ppc64le
  + quay.io/devspaces/iib:3.12-v4.13-640356-533286-ppc64le
  + quay.io/devspaces/iib:3.12-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.12-v4.12-640355-533281-ppc64le
  + quay.io/devspaces/iib:3.12-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.12-v4.11-640352-533277-ppc64le
  + quay.io/devspaces/iib:3.12-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: copyIIBsToQuay/2323: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: sync-to-downstream_3.x/5743: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5615 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.12 :: operator-bundle_3.x/2477: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5743 triggered

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1680: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1680: SUCCESS

3.12.0-CI

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: copyIIBsToQuay/2324: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: sync-to-downstream_3.x/5747: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5619 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.12 :: operator-bundle_3.x/2478: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5747 triggered

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1681: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1681: SUCCESS

3.12.0-CI

@devstudio-release
Copy link

Build 3.12 :: copyIIBsToQuay/2324: SUCCESS

3.12
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.12-43
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.14-640856-533291-s390x
  + quay.io/devspaces/iib:3.12-v4.14-s390x
  + quay.io/devspaces/iib:next-v4.14-s390x
  + quay.io/devspaces/iib:3.12-v4.13-640855-533286-s390x
  + quay.io/devspaces/iib:3.12-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.12-v4.12-641181-533281-s390x
  + quay.io/devspaces/iib:3.12-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.12-v4.11-641180-533277-s390x
  + quay.io/devspaces/iib:3.12-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.14-640856-533291-x86_64
  + quay.io/devspaces/iib:3.12-v4.14-x86_64
  + quay.io/devspaces/iib:next-v4.14-x86_64
  + quay.io/devspaces/iib:3.12-v4.13-640855-533286-x86_64
  + quay.io/devspaces/iib:3.12-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.12-v4.12-641181-533281-x86_64
  + quay.io/devspaces/iib:3.12-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.12-v4.11-641180-533277-x86_64
  + quay.io/devspaces/iib:3.12-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.14-640856-533291-ppc64le
  + quay.io/devspaces/iib:3.12-v4.14-ppc64le
  + quay.io/devspaces/iib:next-v4.14-ppc64le
  + quay.io/devspaces/iib:3.12-v4.13-640855-533286-ppc64le
  + quay.io/devspaces/iib:3.12-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.12-v4.12-641181-533281-ppc64le
  + quay.io/devspaces/iib:3.12-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.12-v4.11-641180-533277-ppc64le
  + quay.io/devspaces/iib:3.12-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants