Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update security best practices doc #2848

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Jan 20, 2025

What does this pull request change?

I've updated some content on the security best practices section: https://eclipse.dev/che/docs/stable/overview/security-best-practices/

What issues does this pull request fix or reference?

Part of verification: https://issues.redhat.com/browse/CRW-7851

Specify the version of the product this pull request applies to

DS 3.18 / Che 7.95

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@dkwon17 dkwon17 requested review from deerskindoll and a team as code owners January 20, 2025 15:23
@dkwon17 dkwon17 requested a review from svor January 20, 2025 15:23
Copy link

github-actions bot commented Jan 20, 2025

🎊 Navigate the preview: https://678e6bdf2d8c07262567311e--eclipse-che-docs-pr.netlify.app 🎊

Copy link

github-actions bot commented Jan 20, 2025

Click here to review and test in web IDE: Contribute

Learn more about project provisioning in the xref:administration-guide:provisioning-namespaces-in-advance.adoc[product documentation].
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the current link was incorrect. I've updated it to the correct link, and also, I've used xref: instead of link:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Learn more about project provisioning in the xref:administration-guide:provisioning-namespaces-in-advance.adoc[product documentation].
Learn more about project provisioning in the xref:provisioning-namespaces-in-advance.adoc[].

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


|events
|watch
|"list", "watch"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For events, the list permissions are also granted:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants