Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix validation errors and warnings #2766

Merged
merged 2 commits into from
Aug 8, 2024
Merged

fix validation errors and warnings #2766

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1619f3e
fix validation errors and warnings
mkuznyetsov Jul 31, 2024
8335705
fixup! fix validation errors and warnings
mkuznyetsov Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions modules/administration-guide/pages/configuring-network-policies.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,11 @@ spec:
policyTypes:
- Ingress
----
====
+
<1> The {prod-short} namespace.
The default is `{prod-namespace}`.
<2> The empty `podSelector` selects all Pods in the {orch-namespace}.

====
+
* OPTIONAL: In case you applied link:https://docs.openshift.com/container-platform/{ocp4-ver}/networking/network_policy/multitenant-network-policy.html[Configuring multitenant isolation with network policy], you also must apply `allow-from-openshift-apiserver` and `allow-from-workspaces-namespaces` NetworkPolicies to `{prod-namespace}`.
The `allow-from-openshift-apiserver` NetworkPolicy allows incoming traffic from `openshift-apiserver` namespace to the `devworkspace-webhook-server` enabling webhooks.
The `allow-from-workspaces-namespaces` NetworkPolicy allows incoming traffic from each user project to `che-gateway` pod.
Expand All @@ -70,11 +69,10 @@ spec:
policyTypes:
- Ingress
----
====
+
<1> The {prod-short} namespace.
The default is `{prod-namespace}`.
<2> The `podSelector` only selects devworkspace-webhook-server pods
====
+
.`allow-from-workspaces-namespaces.yaml`
====
Expand All @@ -98,11 +96,11 @@ spec:
policyTypes:
- Ingress
----
====
+
<1> The {prod-short} namespace.
The default is `{prod-namespace}`.
<2> The `podSelector` only selects che-gateway pods
====
+

.Additional resources
* xref:configuring-namespace-provisioning.adoc[]
Expand Down
1 change: 0 additions & 1 deletion modules/administration-guide/pages/creating-a-telemetry-plugin.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ This document describes the steps required to extend the {prod-short} telemetry

A finished example of the telemetry backend is available link:https://github.com/che-incubator/devworkspace-telemetry-example-plugin[here].

[discrete]
== Creating a server that receives events

For demonstration purposes, this example shows how to create a server that receives events from our telemetry plugin and writes them to standard output.
Expand Down
4 changes: 2 additions & 2 deletions modules/administration-guide/pages/installing-che-in-the-cloud.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
:keywords: overview, running-che-in-the-cloud, installing-che-in-the-cloud
:navtitle: Installing {prod-short} in the cloud

[id="installing-{prod-id-short}-locally"]
[id="installing-{prod-id-short}-in-the-cloud"]
= Installing {prod-short} in the cloud

Deploy and run {prod} in the cloud.
Expand All @@ -16,7 +16,7 @@ Deploy and run {prod} in the cloud.

== Deploying {prod-short} in the cloud

Follow the instructions below to start the {prod-short} Server in the cloud using the `{prod-cli}` tool.
Follow the instructions below to start the {prod-short} Server in the cloud by using the `{prod-cli}` tool.

* xref:installing-che-on-openshift-using-cli.adoc[]
* xref:installing-che-on-openshift-using-the-web-console.adoc[]
Expand Down
1 change: 0 additions & 1 deletion modules/end-user-guide/pages/starting-a-workspace-from-a-raw-devfile-url.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ You can pass your personal access token to the URL to access a devfile from *pri
----
pass:c,a,q[{prod-url}]#__https://__<token>__@__<host>__/__<path_to_devfile> <1>
----
+
<1> Your personal access token that you generated on the Git provider's website.
+
This works for GitHub, GitLab, Bitbucket, Microsoft Azure, and other providers that support Personal Access Token.
Expand Down
Loading