Implemented an ability to reject the authorisation opt-out flag from the dashboard #972

olexii4 · 2023-11-02T16:28:51Z

What does this PR do?

This PR adds the ability to reject the authorization opt-out flag from the dashboard. It revamps the Git Services tab on the User Preferences page to show the Git providers current authorization state (accepted, rejected, or neither), and adds a way to clear the rejected authorization flag for a provider.

Screencast

Git.providers.authorization.mp4

Screenshots

What issues does this PR fix or reference?

fixes eclipse-che/che#22600

Is it tested? How?

Deploy Eclipse Che and configure OAuth 2.0 for a Git provider
Open the Git Services tab and check the Git provider authorization state, it should be neither accepted nor rejected.
Start creating a new workspace from the remote repository, and reject the authorization request.
Open the Git Services tab and check the provider authorization state, it should be rejected.
Open the actions list and click the Clear button to remove the authorization flag for the selected provider.
Start creating a new workspace from the remote repository, and accept the authorization request.
Open the Git Services tab and the provider authorization state, it should be accepted.

openshift-ci · 2023-11-02T16:28:57Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

che-bot · 2023-11-02T16:29:07Z

Click here to review and test in web IDE:

packages/dashboard-backend/src/devworkspaceClient/services/devWorkspacePreferencesApi.ts

packages/dashboard-frontend/src/pages/UserPreferences/GitServicesTab/ProviderIcon/index.tsx

packages/dashboard-frontend/src/pages/UserPreferences/GitServicesTab/__tests__/index.spec.tsx

packages/dashboard-backend/src/routes/api/workspacePreferences.ts

packages/dashboard-frontend/src/pages/UserPreferences/GitServicesTab/index.tsx

packages/dashboard-backend/src/routes/api/workspacePreferences.ts

packages/dashboard-frontend/src/store/GitOauthConfig/index.ts

github-actions · 2023-11-08T15:33:17Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-972

github-actions · 2023-11-08T17:18:22Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-972

github-actions · 2023-11-08T17:28:13Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-972

Signed-off-by: Oleksii Orel <[email protected]>

codecov · 2023-11-10T15:14:48Z

Codecov Report

Attention: 195 lines in your changes are missing coverage. Please review.

Comparison is base (4e2738d) 85.15% compared to head (1abef30) 84.96%.
Report is 7 commits behind head on main.

Files	Patch %	Lines
...shboard-frontend/src/store/GitOauthConfig/index.ts	61.25%	62 Missing ⚠️
...spaceClient/services/devWorkspacePreferencesApi.ts	37.89%	59 Missing ⚠️
...d-frontend/src/services/backend-client/oAuthApi.ts	26.08%	17 Missing ⚠️
...src/pages/UserPreferences/GitServicesTab/index.tsx	80.26%	15 Missing ⚠️
...ard-backend/src/routes/api/workspacePreferences.ts	79.03%	13 Missing ⚠️
...rPreferences/GitServicesTab/ProviderIcon/index.tsx	93.51%	7 Missing ⚠️
...hboard-frontend/src/store/FactoryResolver/index.ts	0.00%	7 Missing ⚠️
...ackages/dashboard-backend/src/models/restParams.ts	0.00%	5 Missing ⚠️
...s/UserPreferences/ContainerRegistriesTab/index.tsx	66.66%	3 Missing ⚠️
...frontend/src/services/backend-client/factoryApi.ts	0.00%	3 Missing ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
- Coverage   85.15%   84.96%   -0.20%     
==========================================
  Files         380      384       +4     
  Lines       39189    39723     +534     
  Branches     2522     2545      +23     
==========================================
+ Hits        33373    33752     +379     
- Misses       5789     5944     +155     
  Partials       27       27

Flag	Coverage Δ
unittests	`84.96% <70.27%> (-0.20%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-11-13T10:09:37Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-972

Signed-off-by: Oleksii Kurinnyi <[email protected]>

ibuziuk · 2023-11-13T13:58:48Z

@olexii4 could you please provide more details in the PR description e.g. demo / mockups / how to verify etc?
we might be able to address eclipse-che/che#22631 as part of this PR cc: @tolusha PR needs your approval

all configured git services should be shown under the GitServices Tab and persist after che-server restarts
if the service is authorized we should probably show some indicator e.g. green check mark

Signed-off-by: Oleksii Kurinnyi <[email protected]>

akurinnoy · 2023-11-13T14:27:37Z

@ibuziuk Since Oleksii is on PTO I'm going to update the description

github-actions · 2023-11-13T14:37:47Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-972

dmytro-ndp

PR looks good to merge, because I was able to reject GitLab OAuth access token using Che > Dashboard > User Preferences > Git Services tab, which is the goal of the PR.

akurinnoy · 2023-11-17T10:35:50Z

@dmytro-ndp

Do you know which Git provider token the Che Dashboard is able to revoke?

GitHub and Bitbucket should be able to.

openshift-ci · 2023-11-21T09:04:38Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, dmytro-ndp, ibuziuk, olexii4, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

devstudio-release · 2023-11-21T12:12:08Z

Build 3.11 :: dashboard_3.x/400: Console, Changes, Git Data

devstudio-release · 2023-11-21T12:13:57Z

Build 3.11 :: sync-to-downstream_3.x/5336: Console, Changes, Git Data

devstudio-release · 2023-11-21T12:15:16Z

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5198: Console, Changes, Git Data

devstudio-release · 2023-11-21T13:34:15Z

Build 3.11 :: push-latest-container-to-quay_3.x/3724: Console, Changes, Git Data

devstudio-release · 2023-11-21T13:35:16Z

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5198:

dashboard : 3.x :: Build 57095652 : quay.io/devspaces/dashboard-rhel8:3.11-26
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3724 triggered

devstudio-release · 2023-11-21T13:35:18Z

Build 3.11 :: update-digests_3.x/4966: Console, Changes, Git Data

devstudio-release · 2023-11-21T13:35:20Z

Build 3.11 :: dashboard_3.x/400:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5336 triggered

devstudio-release · 2023-11-21T13:36:22Z

Build 3.11 :: operator-bundle_3.x/2306: Console, Changes, Git Data

devstudio-release · 2023-11-21T13:40:15Z

Build 3.11 :: sync-to-downstream_3.x/5338: Console, Changes, Git Data

devstudio-release · 2023-11-21T13:40:46Z

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5199: Console, Changes, Git Data

devstudio-release · 2023-11-21T14:01:24Z

Build 3.11 :: push-latest-container-to-quay_3.x/3725: Console, Changes, Git Data

devstudio-release · 2023-11-21T14:09:32Z

Build 3.11 :: get-sources-rhpkg-container-build_3.x/5199:

devspaces-operator-bundle : 3.x :: Build 57098705 : quay.io/devspaces/devspaces-operator-bundle:3.11-81
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/3725 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.11-28
- quay.io/devspaces/configbump-rhel8:3.11-6
- quay.io/devspaces/dashboard-rhel8:3.11-26
- quay.io/devspaces/devfileregistry-rhel8:3.11-16
- quay.io/devspaces/devspaces-rhel8-operator:3.11-10
- quay.io/devspaces/idea-rhel8:3.11-10
- quay.io/devspaces/pluginregistry-rhel8:3.11-6
- quay.io/devspaces/server-rhel8:3.11-15
- quay.io/devspaces/traefik-rhel8:3.11-4
- quay.io/devspaces/udi-rhel8:3.11-8
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.12.0-202311021630.p0.gb17014f.assembly.stream
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.12.0-202311021630.p0.g03e5b13.assembly.stream
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

devstudio-release · 2023-11-21T14:09:34Z

Build 3.11 :: copyIIBsToQuay/2176: Console, Changes, Git Data

devstudio-release · 2023-11-21T14:09:36Z

Build 3.11 :: sync-to-downstream_3.x/5338:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5199 triggered; /job/DS_CI/job/dsc_3.x triggered;

devstudio-release · 2023-11-21T14:09:37Z

Build 3.11 :: operator-bundle_3.x/2306:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5338 triggered

devstudio-release · 2023-11-21T14:11:28Z

Build 3.11 :: dsc_3.x/1572: Console, Changes, Git Data

devstudio-release · 2023-11-21T14:12:22Z

Build 3.11 :: update-digests_3.x/4966:

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/2306 triggered

devstudio-release · 2023-11-21T14:20:17Z

Build 3.11 :: dsc_3.x/1572:

3.11.0-CI

devstudio-release · 2023-11-21T15:15:13Z

Build 3.11 :: copyIIBsToQuay/2176:

3.11
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.11-81
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-625582-533291-s390x
  + quay.io/devspaces/iib:3.11-v4.14-s390x
  + quay.io/devspaces/iib:next-v4.14-s390x
  + quay.io/devspaces/iib:3.11-v4.13-625734-533286-s390x
  + quay.io/devspaces/iib:3.11-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.11-v4.12-625721-533281-s390x
  + quay.io/devspaces/iib:3.11-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.11-v4.11-625713-533277-s390x
  + quay.io/devspaces/iib:3.11-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-625582-533291-x86_64
  + quay.io/devspaces/iib:3.11-v4.14-x86_64
  + quay.io/devspaces/iib:next-v4.14-x86_64
  + quay.io/devspaces/iib:3.11-v4.13-625734-533286-x86_64
  + quay.io/devspaces/iib:3.11-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.11-v4.12-625721-533281-x86_64
  + quay.io/devspaces/iib:3.11-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.11-v4.11-625713-533277-x86_64
  + quay.io/devspaces/iib:3.11-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-625736-533291-ppc64le
  + quay.io/devspaces/iib:3.11-v4.14-ppc64le
  + quay.io/devspaces/iib:next-v4.14-ppc64le
  + quay.io/devspaces/iib:3.11-v4.13-625734-533286-ppc64le
  + quay.io/devspaces/iib:3.11-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.11-v4.12-625721-533281-ppc64le
  + quay.io/devspaces/iib:3.11-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.11-v4.11-625713-533277-ppc64le
  + quay.io/devspaces/iib:3.11-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le

openshift-ci bot added the do-not-merge/work-in-progress label Nov 2, 2023

olexii4 force-pushed the CHE-22600 branch from 5fab32e to 3ed6a3b Compare November 8, 2023 03:35

olexii4 marked this pull request as ready for review November 8, 2023 03:36

olexii4 requested review from akurinnoy and ibuziuk as code owners November 8, 2023 03:36

openshift-ci bot removed the do-not-merge/work-in-progress label Nov 8, 2023

olexii4 force-pushed the CHE-22600 branch from 3ed6a3b to b9f1929 Compare November 8, 2023 04:09

akurinnoy reviewed Nov 8, 2023

View reviewed changes

feat: add reject the authorisation API

6c94361

Signed-off-by: Oleksii Orel <[email protected]>

olexii4 force-pushed the CHE-22600 branch 2 times, most recently from 2fbcad0 to c57ec26 Compare November 10, 2023 13:34

eclipse-che deleted a comment from codecov bot Nov 10, 2023

olexii4 force-pushed the CHE-22600 branch 2 times, most recently from f438348 to f4114b8 Compare November 10, 2023 13:54

feat: implemented an ability to reject the authorisation opt-out flag

748cbc9

Signed-off-by: Oleksii Orel <[email protected]>

olexii4 force-pushed the CHE-22600 branch from f4114b8 to 748cbc9 Compare November 10, 2023 13:56

fix: code cleanup

d85abfa

Signed-off-by: Oleksii Kurinnyi <[email protected]>

ibuziuk requested a review from tolusha November 13, 2023 13:55

fix: CheTooltip component

5174f24

Signed-off-by: Oleksii Kurinnyi <[email protected]>

ibuziuk requested a review from dmytro-ndp November 14, 2023 14:40

dmytro-ndp approved these changes Nov 17, 2023

View reviewed changes

openshift-ci bot assigned dmytro-ndp Nov 17, 2023

akurinnoy approved these changes Nov 21, 2023

View reviewed changes

openshift-ci bot assigned akurinnoy Nov 21, 2023

ibuziuk approved these changes Nov 21, 2023

View reviewed changes

openshift-ci bot assigned ibuziuk Nov 21, 2023

olexii4 merged commit e5c7031 into main Nov 21, 2023
11 of 13 checks passed

olexii4 deleted the CHE-22600 branch November 21, 2023 12:11

vinokurig mentioned this pull request Apr 22, 2024

Restore the authorisation opt-out functionality #1098

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented an ability to reject the authorisation opt-out flag from the dashboard #972

Implemented an ability to reject the authorisation opt-out flag from the dashboard #972

olexii4 commented Nov 2, 2023 •

edited by akurinnoy

Loading

openshift-ci bot commented Nov 2, 2023

che-bot commented Nov 2, 2023

github-actions bot commented Nov 8, 2023

github-actions bot commented Nov 8, 2023

github-actions bot commented Nov 8, 2023

codecov bot commented Nov 10, 2023 •

edited

Loading

github-actions bot commented Nov 13, 2023

ibuziuk commented Nov 13, 2023

akurinnoy commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

dmytro-ndp left a comment •

edited

Loading

akurinnoy commented Nov 17, 2023

openshift-ci bot commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

Implemented an ability to reject the authorisation opt-out flag from the dashboard #972

Implemented an ability to reject the authorisation opt-out flag from the dashboard #972

Conversation

olexii4 commented Nov 2, 2023 • edited by akurinnoy Loading

What does this PR do?

What issues does this PR fix or reference?

Is it tested? How?

openshift-ci bot commented Nov 2, 2023

che-bot commented Nov 2, 2023

github-actions bot commented Nov 8, 2023

github-actions bot commented Nov 8, 2023

github-actions bot commented Nov 8, 2023

codecov bot commented Nov 10, 2023 • edited Loading

Codecov Report

github-actions bot commented Nov 13, 2023

ibuziuk commented Nov 13, 2023

akurinnoy commented Nov 13, 2023

github-actions bot commented Nov 13, 2023

dmytro-ndp left a comment • edited Loading

Choose a reason for hiding this comment

akurinnoy commented Nov 17, 2023

openshift-ci bot commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

devstudio-release commented Nov 21, 2023

olexii4 commented Nov 2, 2023 •

edited by akurinnoy

Loading

codecov bot commented Nov 10, 2023 •

edited

Loading

dmytro-ndp left a comment •

edited

Loading