Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support a devfile that includes a parent with the storage-type attribute #1303

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jan 23, 2025

What does this PR do?

This PR adds support to the target devfite that includes a parent with the storage-type attribute.

Screenshot/screencast of this PR

Знімок екрана 2025-01-28 о 17 33 51

What issues does this PR fix or reference?

fixes eclipse-che/che#23309

Is it tested? How?

  1. Deploy Eclipse-Che with the image from this PR.
  2. Open Create Workspace and create a new workspace from the source
https://gist.githubusercontent.com/olexii4/dfb21012e08eedf8fc17ae608708fe87/raw/bec54efa905b915695dcb7fc5806cb4b456aa343/devfile.yaml
  1. A new workspace should be created without errors.
  2. Open Workspace details and try to change Storage Type of the target workspace:
Знімок екрана 2025-01-29 о 10 44 07
  1. Change Storage Type widget should include the warning message Storage type is already defined in parent, you cannot change it. and disabled storage-type selector:
Знімок екрана 2025-01-29 о 10 43 31

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Jan 23, 2025

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1303

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1303", name: che-dashboard}]}}]"

Signed-off-by: Oleksii Orel <[email protected]>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1303

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1303", name: che-dashboard}]}}]"

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1303

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1303", name: che-dashboard}]}}]"

@olexii4 olexii4 changed the title feat: add support a devfite that includes a parent with the storage-type attribute feat: add support a devfile that includes a parent with the storage-type attribute Jan 27, 2025
Copy link
Contributor

@akurinnoy akurinnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@olexii4
Copy link
Contributor Author

olexii4 commented Jan 28, 2025

/test v14-dashboard-happy-path
/test v14-e2e-puppeteer

@openshift-ci openshift-ci bot removed the lgtm label Jan 28, 2025
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1303

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1303", name: che-dashboard}]}}]"

…h the storage-type attribute

Signed-off-by: Oleksii Orel <[email protected]>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1303

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1303", name: che-dashboard}]}}]"

…ent with the storage-type attribute

Signed-off-by: Oleksii Orel <[email protected]>
…s a parent with the storage-type attribute

Signed-off-by: Oleksii Orel <[email protected]>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1303

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1303", name: che-dashboard}]}}]"

Copy link

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Jan 29, 2025
@olexii4 olexii4 merged commit a67105b into main Jan 29, 2025
20 checks passed
@olexii4 olexii4 deleted the CHE-23309 branch January 29, 2025 15:15
@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/622: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/622: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/8665 triggered

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8772: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 66520905 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UD] A new workspace cannot be created if the target devfile includes a parent with the storage-type field
5 participants