-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support a devfile that includes a parent with the storage-type attribute #1303
Conversation
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1303 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1303", name: che-dashboard}]}}]" |
Signed-off-by: Oleksii Orel <[email protected]>
…type attribute Signed-off-by: Oleksii Orel <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1303 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1303", name: che-dashboard}]}}]" |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1303 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1303", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
/test v14-dashboard-happy-path |
…torage-type attribute Signed-off-by: Oleksii Orel <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1303 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1303", name: che-dashboard}]}}]" |
…h the storage-type attribute Signed-off-by: Oleksii Orel <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1303 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1303", name: che-dashboard}]}}]" |
…ent with the storage-type attribute Signed-off-by: Oleksii Orel <[email protected]>
…s a parent with the storage-type attribute Signed-off-by: Oleksii Orel <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1303 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1303", name: che-dashboard}]}}]" |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.19 :: dashboard_3.x/622: Console, Changes, Git Data |
Build 3.19 :: sync-to-downstream_3.x/8665: Console, Changes, Git Data |
Build 3.19 :: push-latest-container-to-quay_3.x/5070: Console, Changes, Git Data |
Build 3.19 :: get-sources-rhpkg-container-build_3.x/8771: dashboard : 3.x :: Build 66520420 : quay.io/devspaces/dashboard-rhel9:3.19-9 |
Build 3.19 :: update-digests_3.x/8483: Console, Changes, Git Data |
Build 3.19 :: dashboard_3.x/622: Upstream sync done; /DS_CI/sync-to-downstream_3.x/8665 triggered |
Build 3.19 :: operator-bundle_3.x/4363: Console, Changes, Git Data |
Build 3.19 :: sync-to-downstream_3.x/8666: Console, Changes, Git Data |
Build 3.19 :: get-sources-rhpkg-container-build_3.x/8772: devspaces-operator-bundle : 3.x :: Failed in 66520905 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
This PR adds support to the target devfite that includes a parent with the storage-type attribute.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23309
Is it tested? How?
Storage type is already defined in parent, you cannot change it.
and disabled storage-type selector:Release Notes
Docs PR