Do not cache the service account token in the devWorkspace client

[vinokurig]

What does this PR do?

Remove the DevWorkspaceSingletonClient implementation as it caches the service account token. Use the DevWorkspaceClient with service account token fetch instead.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#23230

Is it tested? How?

1. Start Che with the pull request dashboard image: quay.io/eclipse/che-dashboard:pr-1283
2. Decrease the kubernetes service account token lifetime:

• Scale down the eclipse-che operator deployment to 0 pods.
• Scale down the che-dashboard deployment to 0 pods.
• Add volume:

    - name: kube-api-access-q2nzw
      projected:
        sources:
          - serviceAccountToken:
              expirationSeconds: 600
              path: token
          - configMap:
              name: kube-root-ca.crt
              items:
                - key: ca.crt
                  path: ca.crt
          - downwardAPI:
              items:
                - path: namespace
                  fieldRef:
                    apiVersion: v1
                    fieldPath: metadata.namespace
          - configMap:
              name: openshift-service-ca.crt
              items:
                - key: service-ca.crt
                  path: service-ca.crt
        defaultMode: 420

to the che-dashboard deployment yaml.

• Scale up the che-dashboard deployment to 1 pod.

3. Wait 10 minutes for the service account token is refreshed.
4. Start a workspace.

See: the workspace starts, at least the Checking for the limit of running workspaces step passes. The workspace may not start as the che-operator is turned off. If turn on the operator, the token lifetime will be restored to one year.

Release Notes

Docs PR

[che-bot]

Click here to review and test in web IDE:

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1283

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1283", name: che-dashboard}]}}]"

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1283

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1283", name: che-dashboard}]}}]"

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.61%. Comparing base (70b6ddd) to head (838fc8c).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1283      +/-   ##
==========================================
- Coverage   91.85%   91.61%   -0.25%     
==========================================
  Files         499      498       -1     
  Lines       45654    45590      -64     
  Branches     3191     3164      -27     
==========================================
- Hits        41937    41768     -169     
- Misses       3683     3791     +108     
+ Partials       34       31       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[olexii4]

LGTM

[olexii4]

@vinokurig Could you rebase it to the main branch and fix all conflicts?

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1283

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1283", name: che-dashboard}]}}]"

[artaleks9]

Verified on Eclipse Che with quay.io/eclipse/che-dashboard:pr-1283 according to PR check description - works properly

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, olexii4, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[devspacesbuild]

Build 3.19 :: dashboard_3.x/611: Console, Changes, Git Data

[devspacesbuild]

Build 3.19 :: sync-to-downstream_3.x/8443: Console, Changes, Git Data

[devspacesbuild]

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8545: Console, Changes, Git Data