Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin nanoid #1274

Merged
merged 1 commit into from
Dec 17, 2024
Merged

chore: pin nanoid #1274

merged 1 commit into from
Dec 17, 2024

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR pins the version of the nanoid package.

Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy akurinnoy requested a review from SDawley December 11, 2024 12:44
@akurinnoy akurinnoy self-assigned this Dec 11, 2024
@che-bot
Copy link
Contributor

che-bot commented Dec 11, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1274

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1274", name: che-dashboard}]}}]"

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (0d37c7e) to head (093cc9e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1274      +/-   ##
==========================================
- Coverage   91.71%   91.58%   -0.13%     
==========================================
  Files         499      499              
  Lines       45651    45651              
  Branches     3175     3165      -10     
==========================================
- Hits        41870    41811      -59     
- Misses       3749     3810      +61     
+ Partials       32       30       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibuziuk
Copy link
Member

ibuziuk commented Dec 13, 2024

\retest

Copy link

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy akurinnoy merged commit b5d9c74 into main Dec 17, 2024
20 of 21 checks passed
@akurinnoy akurinnoy deleted the bump-deps branch December 17, 2024 10:44
@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/604: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/604: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/8325 triggered

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: get-sources-rhpkg-container-build_3.x/8422: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 66228871 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

akurinnoy added a commit that referenced this pull request Jan 14, 2025
Signed-off-by: Oleksii Kurinnyi <[email protected]>
akurinnoy added a commit that referenced this pull request Jan 15, 2025
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants