Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Lerna #1229

Merged
merged 1 commit into from
Oct 23, 2024
Merged

chore: remove Lerna #1229

merged 1 commit into from
Oct 23, 2024

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Oct 17, 2024

What does this PR do?

Remove lerna package.

What issues does this PR fix or reference?

fixes eclipse-che/che#23198

Copy link

openshift-ci bot commented Oct 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@che-bot
Copy link
Contributor

che-bot commented Oct 17, 2024

Click here to review and test in web IDE: Contribute

@olexii4 olexii4 force-pushed the lerna branch 2 times, most recently from 472d93f to c90d531 Compare October 17, 2024 23:54
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.96%. Comparing base (27ec6a0) to head (f0f6870).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1229      +/-   ##
==========================================
+ Coverage   89.88%   89.96%   +0.08%     
==========================================
  Files         445      445              
  Lines       46024    46024              
  Branches     3092     3101       +9     
==========================================
+ Hits        41370    41407      +37     
+ Misses       4618     4581      -37     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1229

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1229", name: che-dashboard}]}}]"

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1229

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1229", name: che-dashboard}]}}]"

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1229

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1229", name: che-dashboard}]}}]"

@olexii4 olexii4 marked this pull request as ready for review October 21, 2024 13:00
@olexii4 olexii4 requested a review from mkuznyetsov October 21, 2024 13:00
@olexii4
Copy link
Contributor Author

olexii4 commented Oct 21, 2024

@mkuznyetsov Could you review the make-release.sh script?

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1229

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1229", name: che-dashboard}]}}]"

Signed-off-by: Oleksii Orel <[email protected]>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1229

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1229", name: che-dashboard}]}}]"

Copy link

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, mkuznyetsov, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 5252f8c into main Oct 23, 2024
20 checks passed
@olexii4 olexii4 deleted the lerna branch October 23, 2024 12:53
@devstudio-release
Copy link

Build 3.18 :: dashboard_3.x/577: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

Upgrade or remove Lerna build system from the dashboard
6 participants