Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Swagger to OpenAPI 3.0.0 #1214

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Upgrade Swagger to OpenAPI 3.0.0 #1214

merged 1 commit into from
Oct 9, 2024

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Oct 6, 2024

What does this PR do?

Upgrade Swagger to OpenAPI 3.0.0.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#23182

Is it tested? How?

  1. Deploy Eclipse-Che with the image from this PR.
  2. Open the Dashboard Swagger page with the link {che-server}/dashboard/api/swagger.
  3. Choose Editor Definition and try to execute {che-server}/dashboard/api/editors/devfile with che-editor query param.
  4. It should be possible to add the required parameters to the target request.

Знімок екрана 2024-10-08 о 17 07 40

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Oct 6, 2024

Click here to review and test in web IDE: Contribute

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 61.88119% with 77 lines in your changes missing coverage. Please review.

Project coverage is 89.79%. Comparing base (5c42201) to head (0db5e12).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/dashboard-backend/src/constants/examples.ts 2.53% 77 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1214      +/-   ##
==========================================
- Coverage   90.08%   89.79%   -0.30%     
==========================================
  Files         443      443              
  Lines       45727    45806      +79     
  Branches     3078     3061      -17     
==========================================
- Hits        41194    41131      -63     
- Misses       4493     4640     +147     
+ Partials       40       35       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olexii4 olexii4 force-pushed the CHE-23170 branch 2 times, most recently from 2ffcf00 to dcc1006 Compare October 7, 2024 13:56
Copy link

github-actions bot commented Oct 7, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1214

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1214", name: che-dashboard}]}}]"

Copy link

github-actions bot commented Oct 7, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1214

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1214", name: che-dashboard}]}}]"

@olexii4 olexii4 changed the title Upgrade Swagger to OpenAPI 3.0 Upgrade Swagger to OpenAPI 3.0.0 Oct 7, 2024
Signed-off-by: Oleksii Orel <[email protected]>
Copy link

github-actions bot commented Oct 8, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1214

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1214", name: che-dashboard}]}}]"

Copy link

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 04b25a7 into main Oct 9, 2024
18 of 20 checks passed
@olexii4 olexii4 deleted the CHE-23170 branch October 9, 2024 10:18
@devstudio-release
Copy link

Build 3.18 :: dashboard_3.x/561: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UD] Dashboard swagger does not work properly with API which requires query params
4 participants