Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the oauth items filter with changes from server #1127

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Jun 6, 2024

What does this PR do?

Since che-server returns bitbucket-server for self-hosted Bitbucket authenticators, both oauth1 and oauth2, remove the includes filter.

see #1121

What issues does this PR fix or reference?

fixes eclipse-che/che#22971
DO NOT MERGE: depends on eclipse-che/che-server#689

Is it tested? How?

see eclipse-che/che#22971

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Jun 6, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Jun 6, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1127

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1127", name: che-dashboard}]}}]"

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (9873276) to head (2464a2a).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1127      +/-   ##
==========================================
+ Coverage   89.60%   89.73%   +0.12%     
==========================================
  Files         408      411       +3     
  Lines       41604    41920     +316     
  Branches     2786     2818      +32     
==========================================
+ Hits        37281    37617     +336     
+ Misses       4297     4278      -19     
+ Partials       26       25       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig vinokurig merged commit b4aa64a into main Jun 8, 2024
26 of 27 checks passed
@vinokurig vinokurig deleted the che-22971 branch June 8, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard Git Services tab duplicates status icon if 2 GitHubs configured
3 participants