-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update error page for advance authorization errors #1123
Conversation
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Skipping CI for Draft Pull Request. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1123 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1123", name: che-dashboard}]}}]" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1123 +/- ##
==========================================
+ Coverage 89.60% 89.75% +0.14%
==========================================
Files 408 411 +3
Lines 41604 41932 +328
Branches 2786 2826 +40
==========================================
+ Hits 37281 37634 +353
+ Misses 4297 4274 -23
+ Partials 26 24 -2 ☔ View full report in Codecov by Sentry. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1123 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1123", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
This PR enhances the error page to display advance authorization error messages propagated as response data.
Screencast
https://youtu.be/1BJ5CPf07pw
What issues does this PR fix or reference?
resolves eclipse-che/che#22912
Is it tested? How?
denyUsers
list: