-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecation warning message in the dashboard pod #1119
Conversation
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1119 +/- ##
==========================================
- Coverage 89.60% 89.21% -0.39%
==========================================
Files 408 408
Lines 41604 41604
Branches 2786 2769 -17
==========================================
- Hits 37281 37119 -162
- Misses 4297 4461 +164
+ Partials 26 24 -2 ☔ View full report in Codecov by Sentry. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1119 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1119", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.15 :: dashboard_3.x/498: Console, Changes, Git Data |
Build 3.15 :: sync-to-downstream_3.x/6892: Console, Changes, Git Data |
What does this PR do?
This PR changes the dashboard backend build so the resulting js bundle has no dependency packages included.
Is it tested? How?