Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecation warning message in the dashboard pod #1119

Merged
merged 2 commits into from
May 30, 2024

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented May 29, 2024

What does this PR do?

This PR changes the dashboard backend build so the resulting js bundle has no dependency packages included.

Is it tested? How?

  1. Deploy Eclipse Che and patch CR with this command:
    kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1119", name: che-dashboard}]}}]"
  2. Create and launch a workspace.
  3. Open the dashboard pod logs, there should be no deprecation warnings.

@akurinnoy akurinnoy self-assigned this May 29, 2024
@akurinnoy akurinnoy requested review from olexii4 and ibuziuk as code owners May 29, 2024 11:01
@che-bot
Copy link
Contributor

che-bot commented May 29, 2024

Click here to review and test in web IDE: Contribute

@akurinnoy akurinnoy marked this pull request as draft May 29, 2024 12:03
@akurinnoy akurinnoy marked this pull request as ready for review May 29, 2024 12:52
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (9873276) to head (8bb82b9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1119      +/-   ##
==========================================
- Coverage   89.60%   89.21%   -0.39%     
==========================================
  Files         408      408              
  Lines       41604    41604              
  Branches     2786     2769      -17     
==========================================
- Hits        37281    37119     -162     
- Misses       4297     4461     +164     
+ Partials       26       24       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1119

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1119", name: che-dashboard}]}}]"

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy akurinnoy merged commit c89f94e into main May 30, 2024
17 of 18 checks passed
@akurinnoy akurinnoy deleted the deprecation-warning branch May 30, 2024 15:20
@devstudio-release
Copy link

Build 3.15 :: dashboard_3.x/498: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants