-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autoformat and reconcile to save ant task #1013
Merged
azoitl
merged 8 commits into
eclipse-4diac:freeze
from
ernstblechaPT:add_autoformat_reconcile_to_save_ant_task
Jan 31, 2025
Merged
Add autoformat and reconcile to save ant task #1013
azoitl
merged 8 commits into
eclipse-4diac:freeze
from
ernstblechaPT:add_autoformat_reconcile_to_save_ant_task
Jan 31, 2025
+286
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernstblechaPT
force-pushed
the
add_autoformat_reconcile_to_save_ant_task
branch
from
January 31, 2025 05:19
c5ecad2
to
bbfb2d6
Compare
ernstblechaPT
force-pushed
the
add_autoformat_reconcile_to_save_ant_task
branch
from
January 31, 2025 08:39
bbfb2d6
to
02b99af
Compare
mx990
suggested changes
Jan 31, 2025
plugins/org.eclipse.fordiac.ide.ant/src_ant/org/eclipse/fordiac/ide/ant/ant/SaveBlock.java
Outdated
Show resolved
Hide resolved
resourceFactory); | ||
resourceSet.getResourceFactoryRegistry().getExtensionToFactoryMap().put( // | ||
TypeLibraryTags.DATA_TYPE_FILE_ENDING, // | ||
resourceFactory); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add mappings for ATTRIBUTE_TYPE_FILE_ENDING
.
...e/fordiac/ide/structuredtextfunctioneditor/ui/resource/STFunctionResourceSetInitializer.java
Outdated
Show resolved
Hide resolved
ernstblechaPT
force-pushed
the
add_autoformat_reconcile_to_save_ant_task
branch
from
January 31, 2025 15:19
102eda4
to
a112451
Compare
mx990
approved these changes
Jan 31, 2025
azoitl
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Save-Ant-Task only fixed XML formatting issues in the files when saving.
This adds the reconciler and optionally the autoformatter to the Ant-Task to ensure consistent XML-files