Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoformat and reconcile to save ant task #1013

Conversation

ernstblechaPT
Copy link

@ernstblechaPT ernstblechaPT commented Jan 30, 2025

The Save-Ant-Task only fixed XML formatting issues in the files when saving.

This adds the reconciler and optionally the autoformatter to the Ant-Task to ensure consistent XML-files

Copy link

github-actions bot commented Jan 30, 2025

Test Results

   111 files  ±0     111 suites  ±0   51s ⏱️ +2s
29 179 tests ±0  29 179 ✅ ±0  0 💤 ±0  0 ❌ ±0 
29 180 runs  ±0  29 180 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a112451. ± Comparison against base commit e38512e.

♻️ This comment has been updated with latest results.

@ernstblechaPT ernstblechaPT force-pushed the add_autoformat_reconcile_to_save_ant_task branch from c5ecad2 to bbfb2d6 Compare January 31, 2025 05:19
@ernstblechaPT ernstblechaPT force-pushed the add_autoformat_reconcile_to_save_ant_task branch from bbfb2d6 to 02b99af Compare January 31, 2025 08:39
@ernstblechaPT ernstblechaPT requested a review from mx990 January 31, 2025 08:43
@ernstblechaPT ernstblechaPT marked this pull request as ready for review January 31, 2025 08:43
resourceFactory);
resourceSet.getResourceFactoryRegistry().getExtensionToFactoryMap().put( //
TypeLibraryTags.DATA_TYPE_FILE_ENDING, //
resourceFactory);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add mappings for ATTRIBUTE_TYPE_FILE_ENDING.

@mx990 mx990 requested a review from oberlehner January 31, 2025 14:59
@ernstblechaPT ernstblechaPT force-pushed the add_autoformat_reconcile_to_save_ant_task branch from 102eda4 to a112451 Compare January 31, 2025 15:19
@azoitl azoitl merged commit 480a102 into eclipse-4diac:freeze Jan 31, 2025
4 checks passed
@ernstblechaPT ernstblechaPT deleted the add_autoformat_reconcile_to_save_ant_task branch February 3, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants