Encapsulate global constants in namespace of enclosing type #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update proposals for global constants in ST editor to use qualified name and import enclosing type.
The global cinstants editor uses a file editor input for the ST editor. This adds back support for plain file editor inputs in the resource-for-editor-input factory.
oberlehner
reviewed
Jan 30, 2025
| <With Var="IN"/> | ||
| </Event> | ||
| </EventInputs> | ||
| <EventOutputs> | ||
| <Event Name="CNF" Type="Event" Comment="Execution Confirmation"> | ||
| <Event Name="CNF" Type="Event"> |
There was a problem hiding this comment.
why do you remove the comment here ?
There was a problem hiding this comment.
The interface of function FBs is (re-)generated by the ST reconciler on each save, so any comments are lost. But there should be no way to add any comments in the first place, besides editing the XML file manually.
oberlehner
reviewed
Jan 30, 2025
| @@ -123,7 +123,7 @@ public Change createChange(final IProgressMonitor monitor) throws CoreException, | |||
| if (type instanceof FBType) { | |||
| return createFBDataChange(); | |||
| } | |||
There was a problem hiding this comment.
i think you should check here explicit for global const.
If we rename for example .adp , .dev, .seg ,... this code will be executed.
I don't know if that will work out
There was a problem hiding this comment.
Do we not need to update those other type entries anyhow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encapsulate global constants in namespace of enclosing type: