add TODO and warning about non-path variables not being currently handled in module load environment #4748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dled in module load environment
boegel
reviewed
Jan 29, 2025
|
|
||
| for env_var, search_paths in env_var_requirements: | ||
| for env_var, search_paths in env_var_requirements.items(): |
There was a problem hiding this comment.
@lexming Without the .items() this is horribly wrong, no? How did it pass CI in the previous PR...
There was a problem hiding this comment.
currently env_var_requirements is a list of tuples, this PR changes it to a dict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to discussion in #4653