-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Score-P EasyBlock for future releases and better oneAPI support. #3548
Conversation
The following changes are implemented: - Properly handle Qt5 & Qt6 dependencies for CubeGUI, not only Qt4 - Remove `--with-cube` option, as this is not supported by Score-P 6.0+ - Add dependency handling for GOTCHA, as this option will likely be added with Score-P 9.0+ - Switch to `--with-nocross-compiler-suite=oneapi` if Intel toolchain uses oneAPI compilers (checked via 'oneapi' toolchain option). This allows building Score-P with oneAPI 2024.0.0 and newer. Signed-off-by: Jan André Reuter <[email protected]>
I can split this PR into two, removing the |
See easybuilders/easybuild-easyconfigs#22143 (comment) for a local test with Intel oneAPI EasyConfigs. |
@boegelbot please test @ jsc-zen3 |
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2582401628 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
Some comments that came up with offline discussion with @geimer:
Both could be done in a separate PR to clean things up. |
Instead of going through the defined dependencies in EasyBlock and searching if they are loaded, go through the explicit dependencies in the EasyConfig and pass them instead. This reduces the amount of unnecessary passed configure options. However, this now requires having 'binutils' as an explicit dependency for Score-P, since it requires having the paths for libbfd. Signed-off-by: Jan André Reuter <[email protected]>
Signed-off-by: Jan André Reuter <[email protected]>
@boegelbot please test @ jsc-zen3 |
@SebastianAchilles: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2598003764 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @Thyre! |
The following changes are implemented:
--with-cube
option, as this is not supported by Score-P 6.0+ & recent Scalasca versions--with-nocross-compiler-suite=oneapi
if Intel toolchain uses oneAPI compilers (checked via 'oneapi' toolchain option). This allows building Score-P with oneAPI 2024.0.0 and newer.Targeting
5.0.x
, asdevelop
still contains the EasyConfigs Cube-4.3.4-foss-2016a.eb and Scalasca-2.3-foss-2016a.eb, still using--with-cube=
as the option.