Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "remove unused custom easyblock for PSI (psi.py)" #3186

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Revert "remove unused custom easyblock for PSI (psi.py)" #3186

merged 1 commit into from
Feb 8, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Feb 8, 2024

Needed for PSI4.

@branfosj branfosj added this to the 5.0 milestone Feb 8, 2024
@bartoldeman
Copy link
Contributor

Indeed, for PSI4-1.7-foss-2021b.eb. ouch, sorry for missing that!

bartoldeman
bartoldeman approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartoldeman bartoldeman merged commit 47fae85 into 5.0.x Feb 8, 2024
33 checks passed
@branfosj branfosj deleted the revert-3184-20240208132538_new_pr_cVUeQKlcyt branch February 8, 2024 15:02
@boegel boegel mentioned this pull request Feb 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoldeman bartoldeman bartoldeman approved these changes

Assignees
No one assigned
Labels
bug fix EasyBuild-5.0 EasyBuild 5.0
Projects
EasyBuild v5.0
Status: No status
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@branfosj @bartoldeman