-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.4.0 #468
Release 2.4.0 #468
Conversation
BSchilperoort
commented
Nov 27, 2024
•
edited
Loading
edited
- Followed all steps outlined in CONTRIBUTING.md https://github.com/eWaterCycle/ewatercycle/blob/main/CONTRIBUTING.md#you-want-to-make-a-release
- Build failed with new conda lock file. Its resolver picked an old pyopenssl version incompatible with the openssl binaries it picked 🙄 . Fixed by pinning newer version in dependencies
All packages need to be on conda to make a new conda lock file. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
==========================================
- Coverage 78.92% 78.89% -0.04%
==========================================
Files 28 28
Lines 1874 1876 +2
Branches 159 159
==========================================
+ Hits 1479 1480 +1
- Misses 336 337 +1
Partials 59 59
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks allright to me. Added a small suggestion.
Thanks for the review @Peter9192 ! |