Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.4.0 #468

Merged
merged 8 commits into from
Dec 4, 2024
Merged

Release 2.4.0 #468

merged 8 commits into from
Dec 4, 2024

Conversation

BSchilperoort
Copy link
Member

@BSchilperoort BSchilperoort commented Nov 27, 2024

@BSchilperoort
Copy link
Member Author

BSchilperoort commented Nov 27, 2024

All packages need to be on conda to make a new conda lock file. Remote BMI is not on conda yet. Done!

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.89%. Comparing base (a4bddc9) to head (4501c81).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ewatercycle/models.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
- Coverage   78.92%   78.89%   -0.04%     
==========================================
  Files          28       28              
  Lines        1874     1876       +2     
  Branches      159      159              
==========================================
+ Hits         1479     1480       +1     
- Misses        336      337       +1     
  Partials       59       59              
Files with missing lines Coverage Δ
src/ewatercycle/util.py 85.27% <100.00%> (+0.11%) ⬆️
src/ewatercycle/models.py 50.00% <0.00%> (-2.64%) ⬇️

@BSchilperoort BSchilperoort marked this pull request as ready for review December 2, 2024 13:00
@BSchilperoort BSchilperoort requested review from Peter9192 and removed request for Peter9192 December 3, 2024 08:37
Copy link
Collaborator

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks allright to me. Added a small suggestion.

pyproject.toml Outdated Show resolved Hide resolved
@BSchilperoort
Copy link
Member Author

Thanks for the review @Peter9192 !

@BSchilperoort BSchilperoort merged commit 3caa85e into main Dec 4, 2024
5 of 6 checks passed
@BSchilperoort BSchilperoort deleted the release-2.4.0 branch December 4, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants