Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs 22648 Acknowledge change if removed in KeepAll mode #5586

Closed
wants to merge 7 commits into from

Conversation

EugenioCollado
Copy link
Contributor

@EugenioCollado EugenioCollado commented Jan 21, 2025

on_unacknowledged_sample_removed callback is called when best effort writer with keep all history is used, when the history was full but before max_blocking_time a sample was acknowledged, as is_acked was checked before the waiting time, and is not re-checked. This should not happen, as keep all should never drop an unacknowledged sample.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@juanjo4936 juanjo4936 force-pushed the fix/reliable/unacked_sample_removed branch from fa4ed02 to c64314b Compare January 24, 2025 11:46
@juanjo4936 juanjo4936 added this to the v3.2.0 milestone Jan 24, 2025
@github-actions github-actions bot added the ci-pending PR which CI is running label Jan 24, 2025
@juanjo4936 juanjo4936 force-pushed the fix/reliable/unacked_sample_removed branch 2 times, most recently from 8bf74da to 5ef9af9 Compare January 24, 2025 11:55
@juanjo4936 juanjo4936 requested review from richiprosima and removed request for richiprosima January 24, 2025 11:56
@juanjo4936 juanjo4936 marked this pull request as ready for review January 29, 2025 10:21
@juanjo4936 juanjo4936 requested review from richiprosima and removed request for richiprosima January 29, 2025 10:29
@juanjo4936 juanjo4936 force-pushed the fix/reliable/unacked_sample_removed branch from 82ce73c to e2cee93 Compare January 29, 2025 10:33
@juanjo4936 juanjo4936 requested review from richiprosima and removed request for richiprosima January 29, 2025 10:33
@juanjo4936 juanjo4936 force-pushed the fix/reliable/unacked_sample_removed branch from 3101ef6 to d6af9e6 Compare January 29, 2025 15:32
@juanjo4936 juanjo4936 requested review from richiprosima and removed request for richiprosima January 29, 2025 15:33
@juanjo4936 juanjo4936 force-pushed the fix/reliable/unacked_sample_removed branch from 9bbb6fa to 9bc5001 Compare January 31, 2025 08:20
@juanjo4936 juanjo4936 closed this Jan 31, 2025
@juanjo4936 juanjo4936 deleted the fix/reliable/unacked_sample_removed branch January 31, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants