Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Deploying to fly.io #5

Merged
merged 11 commits into from
Nov 13, 2023
Merged

[PR] Deploying to fly.io #5

merged 11 commits into from
Nov 13, 2023

Conversation

LuchoTurtle
Copy link
Member

@LuchoTurtle LuchoTurtle commented Nov 8, 2023

closes #4

This should only be merged after #2

Deploys the app to fly.io (https://imgai.fly.dev/), creates a GH actions pipeline to automate the deployment and also adds a guide document.

The app is currently deployed with a lightweight ResNet-50 model (a few MB) on a Development machine. This is why it works. If I were to use a larger model like BLIP, I wager I'd run into memory issues. In fact, if I add a larger image, the LiveView crashes because of memory issues - which makes sense, it only has 250MB of RAM and 1GB of storage.

@LuchoTurtle LuchoTurtle added documentation Improvements or additions to documentation enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person elixir Pull requests that update Elixir code labels Nov 8, 2023
@LuchoTurtle LuchoTurtle self-assigned this Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #5 (211d580) into main (888ddaf) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           28        28           
=========================================
  Hits            28        28           
Files Coverage Δ
lib/app_web/live/page_live.ex 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@LuchoTurtle
Copy link
Member Author

This should be mergeable 👌

@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Nov 8, 2023
@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Nov 8, 2023
@nelsonic
Copy link
Member

nelsonic commented Nov 11, 2023

@LuchoTurtle the deployment files look good. 👌

When I tested it: https://imgai.fly.dev got internet timeout issues despite having a decent internet connection:

imgai-fails-no-internet.mov

The LiveView connection shouldn't block the image classification. 💭

When it did "work", the following image:

cluttered-home

Was classified as a "Library":

image

In fairness, there are enough books in the image that this is an "OK" classification. 💭

Could you bump the Model up to the biggest one available to maximise the chance of appropriate classification?
Ref: #6

@nelsonic nelsonic mentioned this pull request Nov 11, 2023
4 tasks
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuchoTurtle deployment docs look good. 👌
Please see: #6 🙏

@nelsonic nelsonic merged commit 7de1364 into main Nov 13, 2023
3 checks passed
@nelsonic nelsonic deleted the deploy#4 branch November 13, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed documentation Improvements or additions to documentation elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Deploy to Fly.io 🚀
2 participants