Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Typescript types #307

Merged
merged 2 commits into from
May 7, 2019
Merged

feat: add Typescript types #307

merged 2 commits into from
May 7, 2019

Conversation

jaulz
Copy link
Contributor

@jaulz jaulz commented May 7, 2019

Let me know if anything else is required 😊

@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #307 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #307   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         106    106           
=====================================
  Hits          106    106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4b26f8...ae42451. Read the comment docs.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaulz great addition. thanks. 🎉

@nelsonic nelsonic merged commit 7d9c6b8 into dwyl:master May 7, 2019
@nelsonic
Copy link
Member

nelsonic commented May 7, 2019

@jaulz [email protected] on NPM contains this update. thanks again. 👍

@jaulz
Copy link
Contributor Author

jaulz commented May 7, 2019

@nelsonic cool, thanks 😊

@jaulz jaulz deleted the patch-1 branch May 7, 2019 09:09
@xpolb01
Copy link

xpolb01 commented Jun 12, 2019

@jaulz Please revert as it is breaking previous versions. See #310 (comment)

@nelsonic
Copy link
Member

@xpolb01 NPM does not allow reverting. We can fix the type specs and publish a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants