Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false quote prediction when using wchar_t #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix false quote prediction when using wchar_t #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82e9891
Fix false quote prediction when using wchar_t
nullptr-leo Sep 24, 2016
e0428f9
Merge pull request #1 from dwd/master
Feb 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rapidxml.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1811,9 +1811,9 @@ namespace rapidxml
{
static unsigned char test(Ch ch)
{
if (Quote == Ch('\''))
if (ch < 256 && Quote == Ch('\''))
return internal::lookup_tables<0>::lookup_attribute_data_1[static_cast<unsigned char>(ch)];
if (Quote == Ch('\"'))
if (ch < 256 && Quote == Ch('\"'))
return internal::lookup_tables<0>::lookup_attribute_data_2[static_cast<unsigned char>(ch)];
return 0; // Should never be executed, to avoid warnings on Comeau
}
Expand All @@ -1825,9 +1825,9 @@ namespace rapidxml
{
static unsigned char test(Ch ch)
{
if (Quote == Ch('\''))
if (ch < 256 && Quote == Ch('\''))
return internal::lookup_tables<0>::lookup_attribute_data_1_pure[static_cast<unsigned char>(ch)];
if (Quote == Ch('\"'))
if (ch < 256 && Quote == Ch('\"'))
return internal::lookup_tables<0>::lookup_attribute_data_2_pure[static_cast<unsigned char>(ch)];
return 0; // Should never be executed, to avoid warnings on Comeau
}
Expand Down